OpenStreetMap logo OpenStreetMap

Changeset When Comment
41500717 almost 7 years ago

I've deleted the relation per https://en.wikipedia.org/wiki/Template_talk:Infobox_mapframe#Parameter_disabling_the_display_of_OSM_relation_borders?

66789995 almost 7 years ago

Pok Fu Lam Road is not flooded most of the time, so "ford=yes" is probably incorrect (see ford=*). Again, "access=permissive" is also probably incorrect. Also note that "road", "street", etc. are not abbreviated in street names; and the convention is to use both the Chinese name and the English name in the "name" tag, with the Chinese name first (separated by a space), and to add English/Chinese/Cantonese separately in name:en/name:zh/name:yue.

66789899 almost 7 years ago

Note that "access=permissive" means "open to general traffic until such time as the owner revokes the permission which they are legally allowed to do at any time in the future". If all motor vehicles can use the road then it's better to not have the "permissive" tag. Also, unless bicycles (and horses, etc.) are specifically prohibited from using the street, I don't think those should be indicated either.

66703395 almost 7 years ago

"Sham Chun" is only used to refer to the river, as far as I'm aware.

66467924 almost 7 years ago

Reverting since this is unambiguously incorrect; the Highways Department indicates that the Kong Sham Western Highway is "from Ngau Hom Shek in the north near the shoreline to Lam
Tei in the south" (https://www.hyd.gov.hk/en/publications_and_publicity/publications/hyd_factsheets/doc/e_highways.pdf). "Sham Chun" is also only used for the river because of its history, and the government refers to the bridge as the "Shenzhen Bay Bridge".

66510241 almost 7 years ago

I've partially reverted this changeset; the correct tag combination is "highway=construction" plus "construction=motorway". "construction=yes" is generally ignored by rendering and routing software.

63766295 almost 7 years ago

This isn't an import; no data was added. I changed name:zh-min-nan to name:nan because the Southern Min Wikipedia (which likely originated the OSM use of name:zh-min-nan) predates the creation of the ISO 639 language code "nan". Most name:zh-min-nan uses, especially on countries and major cities, were imported by other users (I replaced almost all of those uses in this series of edits; see changeset/64357571).

61164372 almost 7 years ago

Reverted since I can't find a source that says this actually exists.

65591898 about 7 years ago

The reading of incline=up/down is based on the direction of the way (if the vertical direction changes then split the way where that happens?)

65552654 about 7 years ago

Maybe use one object for the red minibus (share_taxi) terminal and one object for the parking lot?

65112378 about 7 years ago

access=*

65112378 about 7 years ago

Oh. According to the wiki page it should probably be access=no (inaccessible to general public); access=permit isn't listed on that page and might imply that anyone could get a permit to use the path.

65112378 about 7 years ago

What are you referring to in the changeset comment? If the thing you've added as a hedge is actually a group of trees, then you should change it to natural=tree_row (natural=tree_row). Otherwise I can't see anything immediately wrong with what you've added, since all of it appears to exist from the aerial imagery, and nothing is terribly misaligned.

64612222 about 7 years ago

The convention is to use the name without "Station" or "station", since it is already clear from the symbol that it is a station. There is no hard rule but usage is fairly consistent across most regions as far as I'm aware. (The reason the bus stops use "Tai Wai Station" is that the bus stops are named after the station itself.) I will be undoing this change.

64433942 about 7 years ago

Are you sure that the slip road no longer exists? (you also forgot to delete the second half; see changeset/64449695 – you might want to use JOSM instead of iD if you're comfortable with editing, it can be less clunky in some ways)

64449695 about 7 years ago

It does exist but it seems to have been disconnected from its other half for some reason.

64357571 about 7 years ago

No, but in this particular case I wouldn't expect the changes to be controversial in any way, and I endeavoured to check as many of the changes as possible (although this was difficult due to the large number of country relations that were in the dataset). None of the changes impact rendering on the main osm.org map, although I would expect them to significantly improve rendering on localized maps like those of Wikimedia Maps.

• Who would I be discussing this change with? Most of these tags were added by a very small number of users who (possibly incorrectly) imported names from Wikipedia or their own data tables, or were added because of the iD language code bug (see below).
• name:xx keys are based on IETF language tags, at least according to the OSM wiki. All of the language codes involved have relevant codes, so I would expect the keys to use those codes.
• I have chosen to capitalize "Hant" and "Hans" because "Latn" is far more commonly used than "latn", and IETF language tags use the uppercase letter.
• Other variants in use in OSM tags: "zh_hant", "zh-hant", "zh-trad" and "zh-traditional"; "zh_hans", "zh-hans" and "zh-simplified". Their meaning is hopefully unambiguous.
• "zh-min-nan" is not an ISO 639 code and is based on the Wikipedia language code for Southern Min. I changed it to "nan". (It is technically difficult to change a Wikipedia edition's language code, as doing so introduces a large number of technical issues that have still not been resolved for the language edition for which this has been done. The Southern Min Wikipedia predates ISO 639-3 by five years, so there was no standard language code for it at the time of its creation. Nevertheless, iD uses the Wikipedia language codes for multilingual names (the issue has been open for almost four years https://github.com/openstreetmap/iD/issues/2457), introducing tagging errors for several languages.)
• "zh-classical" is not an ISO 639 code and is based on the Wikipedia language code for Classical Chinese (I have no idea why these were imported, to be honest). I changed it to "lzh".
• I changed several "zh_py" tags to "zh_pinyin". The latter is much more commonly used and it is impossible to misinterpret the former as meaning something else.
• I made most country codes uppercase. There are very few objects with these tags, and most of them are unnecessary. I opted to uppercase them where they were used in the dataset to match the IETF language tags.
• "Minor" fixes also include key changes for name:pt-br, name:pt-pt, name_zh_classical, and several other keys. I could not use the JOSM validator because of the large number of country relations, although it may be possible by using the reverter on this changeset.

64220592 about 7 years ago

It seems I took a photo of this four years ago (https://www.mapillary.com/map/im/ut3dcq1_TKgK3eazQz62MA). The sign appears to be just before the junction.

64220592 about 7 years ago

Okay. Is the sign that indicates the end of the highway area at that junction point?

64220592 about 7 years ago

In particular, both ways are one-way and thus only accessible from the down ramp.