OpenStreetMap logo OpenStreetMap

Changeset When Comment
168539020 6 months ago

RE: way/1412580299

As mentioned in previous changeset comments, your fairways shouldn't be intersecting other golf course features, and you shouldn't be using the lollipop style of mapping (use multipolygons instead). Please see previous changeset comments for links to wiki pages and reach out to me if you need help. Thanks.

168488972 6 months ago

RE: way/1412242875

As I explained a couple of months ago in changeset/166523141, you can't intersect golf features like fairways and greens. That is invalid mapping and sets up Q/A tools and needs to be corrected and avoided in the future. Please read the previous comments and reach out if you have any questions. Thanks.

168366434 6 months ago

Thanks. Nice to see this will be correct from the start.

168420210 6 months ago

RE: way/1411687104

The lines that define fairways, roughs, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

79817552 6 months ago

RE: way/765243777

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls.

As the designation of "rough" is arbitrarily decided for the area around the tee box, you might consider joining the two large rough areas into a single rough. Alternatively, you could just leave the rough off the map since anything outside of the fairway kind of defaults to be "rough" if that makes sense.

If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168325501 6 months ago

Hi Yamski,

As I mentioned in a comment on a previous changeset by you (changeset/168241298), you shouldn't have your fairways and greens intersecting. Please make sure this gets fixed and doesn't continue to happen. The link above should contain helpful information about how to map golf courses. Please check it out. Thanks.

168321626 6 months ago

RE: way/894465889

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168323549 6 months ago

RE: way/1410979347

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168280755 6 months ago

RE: way/1410714766

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168229975 6 months ago

99.9% of golf courses aren't lit. Please don't litter this tag on any more golf courses. Thanks.

168244129 6 months ago

RE: way/818555966

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168241298 6 months ago

RE: way/1410423910

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168155115 6 months ago

RE: way/1409848406

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Object that are joining each other should *share* nodes on the border, but not cross over each other. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168117933 6 months ago

RE: way/1409641303

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

168093618 6 months ago

RE: way/915665162

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

167980030 6 months ago

RE: way/699305664

FYI, if you can't leave a gap the entire way around the green, you should exclude the green and share all the boundary nodes on the "inside" of the green if that makes sense. I've gone ahead and fixed it up so you could see how it should be done. Thanks.

167979936 6 months ago

RE: way/699280007

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

167885637 6 months ago

Hi again tomyak,

I saw that you created a multipolygon on the 18th fairway, but it only contained a single object (the outer ring of the fairway). Technically, this is incorrect, as it's a single polygon and doesn't need to be made a multipolygon unless it has some inner feature that's different (like a bunker commonly). I'll go ahead and fix it while I'm here but thought you'd want to know about it so you can avoid that pattern. Thanks.

167925417 6 months ago

RE: way/1207321367

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

167931805 6 months ago

Hey BB,

Thanks for contributing to the map. Please be aware that you need to attach the fairway to the green in situations like this hole. That means that you need to *share* every node at the boundary of the two objects. Thanks!

Have fun mapping and golfing.