b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 167888916 | 6 months ago | I cleaned up the 12th hole in case you want an example of how it should look. Feel free to reach out if you need help in recreating what I've done elsewhere. |
| 167879584 | 6 months ago | RE: way/1405169650 I've pointed out in several previous comments on your changes that you need to stop intersecting your golf course features. In the case above, between a bunker and a rough. You're also doing "lollipop" mapping, which is problematic and should be avoided in favor of proper multipolygons. See the wiki pages (mentioned in previous comments) on how to handle those situations. Thanks. |
| 167849779 | 6 months ago | Hello again Tom, You also don't want to do this thing where you break down a feature into parts like you do with way/1396718878. You'll want to draw the rough as a single polygon and the two bunkers inside and then combine them by selecting all objects and right clicking one of them and selecting "Merge" (I think that's what iD calls it). This will create a proper "multipolygon" with the inner/outer features labelled correctly. Let me know if you have any question and I'll gladly help clarify things. thanks. |
| 167806865 | 6 months ago | RE: way/1396492886 First, can you explain why you split the fairway in half like that? You shouldn't be doing this and I've seen a handful of people do this and I'm trying to make sure it never happens again. I'd really like to understand why first. Second, you shouldn't have your features overlapping like the fairways and the bunkers do in the example above. If you are excluding something like the bunker, you can butt them up against each other and share the boundary nodes, or you can leave a gap between the two, but you do not want to be just crossing them over like you've done. Please correct these. Thanks. |
| 167829746 | 6 months ago | RE: way/1396598176 As mentioned in previous comments on your changesets, golf course elements like bunkers and fairways shouldn't intersect each other. They can share boundary nodes sometimes, but they can't overlap like you've done in the bunker above. Please correct this error and do your best to avoid repeating it in the future. thanks. |
| 167773311 | 6 months ago | Hello Noah, I've removed the mess of triangles around the golf course. I don't know what you were trying to accomplish, but many adjoining triangles is not the answer. Also, a body of water that far from a golf hole is not normally considered a water hazard as the likelihood of a ball going in the water is very low. |
| 167762418 | 6 months ago | RE: way/1396129134 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167721813 | 6 months ago | RE: https://overpass-api.de/achavi/?changeset=167721813 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167656551 | 6 months ago | As I've mentioned twice already (once in changeset/167156687), you can't be crossing fairway lines with other golf features. Not to mention the fact that you are drawing a fairway where another fairway already exists. Please go back and fix your recent changes where you are making the mistake and avoid this in the future as well. Thanks. |
| 167581448 | 6 months ago | Oops |
| 167448932 | 6 months ago | RE: way/1393906427 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. You need to make features wrap around others. For example, the fairway should either fully enclose your tee box, or should fully wrap around it (sharing nodes at the boundary is okay). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167441869 | 6 months ago | RE: way/1393853203 As pointed out in a previous comment on one of your changes (changeset/167156687), golf course elements like fairways, greens, water hazards and the like shouldn't intersect each other. That's one problem. Another is that you drew a fairway here when another fairway already existed. I'm not sure why you're doing that, but clearly that is not the right way to map something. Please see the previous comments and make sure you don't overlap elements in this and future changes to golf courses. Thanks. |
| 167467461 | 6 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167292689 | 7 months ago | RE: way/1392896408 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167276163 | 7 months ago | RE: way/1392736034 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167251322 | 7 months ago | RE: way/1163874364 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167234314 | 7 months ago | I just ran a database query for the US to find out how many streams cross greens and fairways. There are hundreds of them (if not more). It seems highly unlikely that a stream is going to cut straight through a bunker or across a green. No grounds crew or course designer would allow that in my experience. See way/41511216 for example. |
| 167234314 | 7 months ago | Thanks for cleaning up the boundary between the fairway and the green. The same type of boundary rules apply to the boundary between fairways and bunkers like way/1391822912. You can either share nodes between the bunker and the fairway, or you can leave a gap like was done with the bunker on the opposite side of the fairway. Whichever you feel is appropriate. Thanks! |
| 167156687 | 7 months ago | RE: way/1391964098 Hello HobbieWoman, Welcome to OpenStreetMap. Thanks for contributing changes and working to improve the map. The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 167134622 | 7 months ago | RE: way/1391822916 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |