You shouldn't be using the "lollipop" style of mapping as seen in way/1367951144. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features. Please see osm.wiki/Relation:multipolygon and leisure=golf_course#Common_mapping_pitfalls for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

Hello fellow golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples an instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hey there Matthew,

Thanks for your golf contributions. We appreciate your help.

I wanted to point out a small error in what you are doing. An example is the multipolygon relation relation/18829142. I believe you were the one to turn the fairway and green into a multipolygon. That's awesome and much appreciated. But you left the fairway tag on the outer polygon which duplicates the tag on the relation itself and also means that everything inside that outer (including the green) is a fairway, which isn't right. Whenever you make a relation, you need to make sure the outer polygon isn't tagged as well. Let me know if this doesn't make sense. Thanks!

You shouldn't be using adjoining polygons to define a single feature like a fairway in hole #3. You should just use a single feature for the fairway, a single feature for the green, and then select them both and right click and select merge to make it a single object called a multipolygon.

If you need help, please check out the wiki at leisure=golf_course

If you need help after that, please drop a comment here or reach out to me for help.

Thanks for helping out with this MapRoulette challenge!

What exactly are you trying to troubleshoot? Maybe I can help.

Hello fellow golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples an instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create
them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples an instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any
questions, please reply here and I'll gladly help clarify things. Thanks!

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See
osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be *shared*. Please read the wiki for visual examples an instructions
on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls

Whoa! Cool! Thanks archpdx for doing the work on this.

https://ultra.trailsta.sh/#map&m=17.26/44.0406/-123.0713&q=LQhQGcBcE8BsFMBcoAELYENrwE7mWmsCjAA5IrjQC2ARgPayqFoCWAxvQHbD0BuuTKUQoMsAO5ZwzFh27BW1DAHMkMlimKcx8cO3jqWxYopUGNG4yk5d2GSIYuaUAcnjV6AK1aIAZpmVgF0cLKwATenFbDHBzJ1CUAG0UVUgAGmt6AFcuSBxoFABdEOcTJVUSohR3Lx8ARyzdSFZuUBBgUETaBgAPRABvfu76HoBfUcKAblAucRxEpS4AfSUw+ABefxVSRnhCxM4cvOgp0GzIa3hc3EmgA

◉ The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls

Hey there malifica,

I see that you edited one of the fairways incorrectly. If you look at way/1247954535, you added the tag of "golf=fairway" to a multipolygon. It's not uncommon to think that is a correct tag, but the multipolygon already defines what inside that boundary is a fairway and what is a green. So it correctly identifies just the fairway as a fairway, but you have come in and said that *everything* inside that boundary, including the green, is to be considered a fairway. Please be careful in the future when modifying objects that are multipolygons. Thanks.

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls

Thanks for adding golf information to the map. I wanted to let you know that you have added what is called a "lollipop" to the course and those aren't supposed to exist. See the wiki at leisure=golf_course#Common_mapping_pitfalls for how to correctly map those situations.

Thanks for the additions. A couple of comments to improve your mapping if you're interested.
* You shouldn't put names on holes and fairways and greens and such unless the golf course has explicitly named them. You should just use a "ref=1" tag instead of "name=Fairway 1".
* If your fairway surrounds the green, you should select both objects (shift click) and right click to Merge them into what is called a multipolygon.

You can find more information at the golf_course wiki page: leisure=golf_course#Common_mapping_pitfalls

That’s sad to hear. They are 100% wrong. Can you point me to where you heard so that I can prevent this misinformation from spreading any further?

As mentioned in changeset/162300773, you shouldn't be reusing the nodes when the fairways extend all the way around the green. Some sort of fringe should be left or the fairway should come up short and butt up against the green instead of surrounding it.

If you need further clarification, please leave a comment here with any questions and I'll be glad to help out.

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls

Hey there Nat,
Thanks for helping out with my golf cleanup maproulette challenge. One thing to note is that the green and fairway shouldn't share nodes when the fairway fully surrounds the green. There should be a fringe that is left so that there is a gap all the way around the green. Of course, if the fairway doesn't surround the green, but instead butts up against it, then yes, by all means share the nodes between the two objects. Thanks again!

Overlapping fairways and greens is bad, but so is "almost touching". What you should be doing is *sharing* the nodes between the green and the fairway. Take a look at the wiki (leisure=golf_course#Common_mapping_pitfalls) for examples. See way/1361164081 if you want to look at an example.