Hello golf course mapper. If you can't see any fringe around a green, you shouldn't reuse the nodes around the entire green, but instead cut the green out of the fairway polygon and reuse them on the boundary between the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

I see that you are continuing to make fairways and greens overlap. The latest instance I've noticed is way/1370563283. Please see the previously mentioned wiki page on how to properly deal with fairways and greens and let me know if there is something you don't understand so that I can help clarify it. Please respond here so I know you saw this message. Thanks.

It's generally considered a bad idea to completely remove an existing fairway just so you can redraw it from scratch. This erases the history of the object and makes it difficult to compare changes to the objects, especially when they are done across saves. But more importantly, you are currently breaking relations that are set up between the fairway and the green and you're leaving a broken multipolygon relation on just the green. You need to make sure you preserve/recreate that relation if you are going to continue to delete fairways. Once again, ideally you would simply modify the existing fairway boundary instead of deleting it. See osm.wiki/Relation:multipolygon if you need help understanding multipolygons. If you need any help, please reach out. Thanks.

It makes finding history of local changes difficult. If you want to see what was changed in a specific block that is nowhere near your changes, this changeset will be included because it encompasses that block. Yes, 100 changesets is more work, but it's not too much to ask. Trust me, I make dozens of changesets a day. Thanks.

Thanks Mark. Much appreciated.

When drawing the fairway and green, if you can't leave room for a fringe all the way around the green, you shouldn't draw the line for the fairway around the green, but instead butt up against it on the inside and re-use each and ever node of the green. See leisure=golf_course#Common_mapping_pitfalls for some examples.

>people use the same software and overlap fairway and greens all the time.

Yes. And that's really bad. OpenStreetMap is a community sourced repository of all sorts of map data and there are tens of thousands of contributors and millions of users of the data. We need to all be careful to behave as a community and not stomp on other contributor's hard work. Using OSM as a scratch pad by doing some work and then deleting the data is hugely problematic and could lead to you getting banned. It's better to all work together, follow OSM best practices, and come up with a solution and stop bad videos and other instructions from recommending these bad habits. Your instinct to not delete someone else's work to do your own way is right. I'm putting in hundreds of hours to work cleaning up this mess and to have someone come behind me and wreck it again is incredibly frustrating.

I did take a look at Chad's Tool and saw that there is work to get multipolygons/relations working correctly. There is a pull request (https://github.com/chadrockey/TGC-Designer-Tools/pull/143) that is just a week old that might solve your problems. If you could help by giving voice to the issue and applying pressure to getting this code implemented, that would be appreciated.

I understand that might be a problem, but we need to conform to the standards and norms of OpenStreeMap and do things the proper way there and not try to work around it due to a bug or shortcoming of 3rd party software.

Can you let me know what software is causing this problem for you? I've heard of some software not handling multipolygons correctly, but they eventually updated their software to fix that problem. Have you tried updating to the latest version?
I'm not sure what you mean exactly when you say you will make "another fairway" attached to the green. Most of the cases there will just be the single fairway that connects to the green and shares the border nodes. Hopefully that is what you meant.

Re: way/1370057429

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hey Zach, please go back to the notes I left on a previous change from you last week (changeset/163446770). You are crossing greens and fairways and shouldn't be. Please examine the wiki pages and make sure you aren't creating greens and fairways that intersect like in way/834709162. Please leave a comment here so I know that you got this message. Thanks.

Please don't create lollipops like on hole 5 (way/1369777434). Use multipolygons to properly create enclosing features instead. See my previous comments and wiki reference on how to create those. Again, feel free to reach out for help if you don't understand. Thanks.

Hi there JHornberry, as I pointed out in a previous changeset comment (changeset/162903940), you are breaking multipolygon relations when you delete and recreate fairways that are part of a relation. Please see the wiki at osm.wiki/Relation:multipolygon#iD for help in understanding how to deal with multipolygons. Feel free to reach out here if you don't understand something. Please respond here so I know that you've seen this message. Thanks!

Re: way/1369677169 ...

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Thanks for joining the fairways and greens. Much appreciated.

Hey there Thockey,
On hole #5, it's probably best just to join the fairway and the green together and share nodes between them since there isn't a clear break between the two. See leisure=golf_course#Common_mapping_pitfalls for examples of how to map them. Thanks.

Hello fellow golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hi Zach, why are you creating a multipolygon out of two lines (typically most of the fairway on one line and then a short chunk of line that completes the fairway for the other?) Is there something I'm missing? I don't see any use for a multipolygon in that situation.
For example: way/1368431473

Hello fellow golf course mapper. If you can't see any fringe around a green, you shouldn't reuse the nodes around the entire green, but instead cut the green out of the fairway polygon and reuse them on the boundary between the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!