RE: way/1441878752

Please don't use the "lollipop" style of mapping golf course elements as you've done in the URL above. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features like fairways. Please see leisure=golf_course#Common_mapping_pitfalls and osm.wiki/Relation:multipolygon for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

They will be. It takes time to correct years of bad practices. The vast majority of them have already been fixed.

This edit is incorrect and breaks the existing relation.

Please see the wiki that explains this: osm.wiki/ID_understanding_golf_course_relations

thanks

I tried to revert my change, but since you've made additional edits to the area, that creates conflicts that are nearly impossible to resolve. Sorry.

While you're in there, please don't have separate fairways for the main fairway and for the fringe around the green. They really should be a single fairway. Even if there are subtle difference in how the grass is cut. Thanks.

Reverted this and several other changes on this course over the last 24 hours that violate rule #1 of golf course mapping: golf course areas (fairways, greens, roughs, tees, etc) should not intersect each other. The previous versions of these holes were correct. If you need to adjust geometries, please make sure you read the golf_course wiki and follow the rules as laid out there. Thanks.

You made some changes to the green at way/685037079. It used to be a multipolygon with a fringe defined by the outer way/fringe and the green. But somehow the fairway was deleted and the relation between the two is "broken". Not sure what the purpose of the change was. Sometimes you see people deleting a feature entirely and then re-adding it from scratch and wind up with this situation, but that doesn't appear to be the case here.

I'm starting to write a wiki article about how to handle multipolygon relations and golf course mapping, but it doesn't directly match this case, but maybe you'll find it useful how to deal with relations in iD (which can be confusing).

osm.wiki/ID_understanding_golf_course_relations

RE: the area around node/13205320063

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. In the case above where you have a rough next to another rough, all of the nodes at the border should be shared between each rough. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out.

I reverted this change as there were several problems with it.

* You broke up the fairway on the first hole into two line strings and then combined them with a multipolygon. There isn't any reason to do this. It should remain as a single polygon.
* You removed the fringe around the first green. The fringe exists and was drawn correctly.
* When you did remove the fringe, you reused nodes on the outer side of the green which is incorrect when including the green inside the fairway.
* On the second green, you crisscrossed the fairway and green boundaries. They shouldn't intersect as they did.

If you have any questions about this, please reach out. Thanks.

Thanks for helping out with golf courses. Please don't use two fairway areas to define a single fairway (one for the main fairway, and another around the green). Just use one single fairway that goes all the way around. Thanks.

Thanks for letting me know!

Check out the "follow line" feature under Tools. Really handy if you have to re-use points on an existing way.

And since you asked, I spotted this overlap tonight: node/13194759713

Check out this node: node/13191502812. It overlaps the neighboring fairway by mere millimeters, but is enough to trigger Q/A checks looking for egregious overlaps but finding all overlaps, no matter how small.

If you're interested in continuing golf course mapping long term, you might want to consider looking into using JOSM to do your edits. There are tools in there that make editing much easier. (But the interface takes getting used to.) For example, when I'm sharing the nodes on a border between two objects, I can just get one node on an existing node, and then determine the direction to travel by clicking on a second node, and then just press and hold "F" to make it continue joining all nodes on the existing path. Incredibly helpful.

Please be careful with golf course edits. You set obvious fairways as "rough" or "green" instead of properly setting them to "fairway". Thanks.

Thanks for getting back to me Wade. I have Q/A scripts that look at all the changes every day and generate a report. This is the first time your name popped up, and I believe they were all right in that area. I can DM you a list of all of the URLs in the past 24 hours that showed problems. Thanks for working to improve. It's greatly appreciated.

Don't worry, I already chastised myself for this mistake!

RE: way/1435170498

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out.

RE: way/1434444359

Hello Doctor,

Thanks for the golf course contributions, but there are a bunch of problems with this hole as you've mapped it that cause others to clean up behind you.

* you split the green area into two different ways and joined them up with a multipolygon. That is not the correct use of a multipolygon here.
* you created a green outside an existing green. I think you were trying to create a fairway fringe around the green.
* you overlapped the fringe polygon with the existing fairway polygon instead of extending the existing fairway around the green. This is also incorrect.

I'm happy to help you golf courses correctly. Please be careful going forward and reach out if you aren't sure how to map something. Also, you might want to visit the golf_course wiki at osm.wiki.

Thanks for the contributions jwelchjunk. Just to let you know, the tee box (golf=tee) shouldn't have a name. I'll go ahead and clean that up for this course, but wanted to let you know for your future mapping projects. Thanks!

When there is no clear delineation between what is rough and non-rough, there really is no need to draw in the rough. By this, I mean, I couldn't see any different between the area inside the rough vs. outside the rough. There were no distinct mower lines or other physical boundary, so it's just an arbitrary area that probably shouldn't be mapped.

Hey NJ,

I'm going to revert these changes as they are incorrect. It's not really your fault, as iD (the editor that you used) doesn't make it obvious that these were already fairways. They are part of a "multipolygon" relation where the fairway and green are paired together and everything inside the fairway EXCEPT the green defines the fairway.

In the future, if you see what looks like a fairway and iD claims it is a "Line", check first to see if it is part of a relation.

I'm going to try to create a wiki page to better describe this. This is what I have so far: osm.wiki/ID_understanding_golf_course_relations