OpenStreetMap logo OpenStreetMap

Changeset When Comment
127593818 about 3 years ago

Hi,

landuse=residential is commonly used for this sort of thing, so I wouldn't exactly say that it's wrong.

That said, if you do opt for this style of tagging, building=apartments would likely be more appropriate than just building=yes.
---

Published using OSMCha: https://osmcha.org/changesets/127593818

127634493 about 3 years ago

There should not be turn restrictions. The appropriate access tags are enough.
---

Published using OSMCha: https://osmcha.org/changesets/127634493

71082661 about 3 years ago

Hi,

Thanks for the edit!

Please just note that "unclassified roads" don't quite match up with these roads here. "Unclassified" basically means a very minor road that is used for through traffic. These roads are minor, but they are only used to access the school, so they should instead be service roads.

Also, these roads should not be named. The name of things on the map should match what street signs say on the ground. If there are no street signs, it shouldn't have a name.

Thanks again!

-John

125591109 about 3 years ago

Hi,

You should never use copyrighted data to map in OSM. You have included a link to Google Maps (which is copyrighted) in the tags for this road. Please do not do this. See osm.org/copyright

126874751 about 3 years ago

Also, to add to that list, you should never create a "no U-turn" restriction unless there is a sign that says so.

126874751 about 3 years ago

To clarify my point about "turning onto a one-way street", I mean turning onto one going in the wrong direction. Even if there is a "do not enter" or "wrong way" sign present, you should not create a restriction.

126874751 about 3 years ago

Also, it looks like you again were adding numerous unsigned turn restrictions at node/254218138 . Please do not do this.

Under any of the following conditions, you should not create a turn restriction relation:

- You are trying to express that you can't turn onto a one-way street.
- You are trying to express that you can't enter a street that has access=no or equivalent.
- There is no sign indicating the restriction. (under select circumstances one can still be created, but you should also tag it with implicit=yes)

An example of that last note is to restrict right turns at a main intersection when there is a slip road that drivers are supposed to use. For example: relation/13066392

All of these relations are duplicate information, and add clutter to the map. Please stop making them.

Thanks,
-John

126874751 about 3 years ago

Hi,

Please try to break up your changesets so that they're smaller and more targeted. For example, one changeset could be for settings surface tags, while another could be for setting maxspeeds. Or, if you want to do a general purpose changeset like this one, please try to contain it to a smaller area than this, so it's easier to review.

Thanks for the updates!

-John
---

Published using OSMCha: https://osmcha.org/changesets/126874751

119031721 about 3 years ago

Is it standard for the "operator" key to be used for the name that accompanies the reporting mark? "Metro-North Railroad" is more commonly used to refer to the railroad.

126747806 about 3 years ago

Hi, and thanks for joining OSM!

Overall, this is a good edit. There's lots of stores that need to be added to the map.

There are a couple things I had to fix:
- It looks like you deleted a couple address points. These points are important, as they help people look up where an address is.
- It looks like you set a whole building to be named "Fratelli's Trattoria", though it includes other businesses too (e.g. the Black Cow).
- When entering the name of a place, the rule of thumb is to enter it exactly as the place displays it. As such, I changed the name you added from "10520 Burgers" to "105 Twenty Bar and Grill", as that is how they name themselves.

That aside, thanks for the good work! For every store you map, we get a little closer to being a viable alternative to some bigger map apps, when it comes to finding stores. OSM is relatively weak in comparison for this specific use.
---

Published using OSMCha: https://osmcha.org/changesets/126747806

126066951 about 3 years ago

Please see changeset/126631410 for the changeset in which this was reverted.

126067087 about 3 years ago

Unfortunately I've had to revert this; see changeset/126066951
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/126067087

126066951 about 3 years ago

Hi,

Unfortunately, I've had to revert this changeset. Highway classifications in New York now follow the ACC codes provided by NYSDOT. The code for this road would make it highway=trunk.

highway=trunk (in this region, at least) no longer is used to denote that a road is limited-access, or higher performance in any way. highway=motorway and highway=trunk together form a network of the most important roads, suitable for long distance travel. highway=motorway on top of that implies that it is a controlled-access road.

If you wish to convey that a road is an "expressway" (high performance, but still some intersections, stop lights, etc.), please use the expressway=yes tag.

Sorry again that I had to revert this, but the new classification system has many benefits, and the state is more unified than it has been before.

Thanks for your understanding,

-John
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/126066951

122232822 over 3 years ago

Hi again,

Just commented on one of your other changesets. Again, I unfortunately had to revert parts of this changeset. I doubt that any speed limit signs would apply to the parking lots here, so I've removed the maxspeed tag from the ways within them. I've retained the speed limits on the more prominent roads here, though.

Let me know if you have any questions!

-John
---

Published using OSMCha: https://osmcha.org/changesets/122232822

122232878 over 3 years ago

Hi,

Thanks for contributing to OSM. I appreciate that you separated out each of your modifications to different changesets, it helps immensely with reviewing them.

In the case of this changeset, I've had to revert part of it. Most of the roads that you marked as tertiary don't meet the requirements for this tag. I did make one exception to the revert, that being Service Center Road between Audubon Parkway and Flint Road. It does serve as a bit more of a connector, so I've tagged it as unclassified. This is similar to tertiary, but for roads that are less important. Flint Road is tertiary, and you'd likely agree that Service Center Road is less important than it. Thus, the unclassified tag makes sense here.

Sorry to have to revert some of your work here, but if you want to keep mapping, feel free to ask me for advice! I'd be happy to help.

-John
---

Published using OSMCha: https://osmcha.org/changesets/122232878

122232878 over 3 years ago

Hi,

Thanks for contributing to OSM. I appreciate that you separated out each of your modifications to different changesets, it helps immensely with reviewing them.

In the case of this changeset, I've had to revert part of it. Most of the roads that you marked as tertiary don't meet the requirements for this tag. I did make one exception to the revert, that being Service Center Road between Audubon Parkway and Flint Road. It does serve as a bit more of a connector, so I've tagged it as unclassified. This is similar to tertiary, but for roads that are less important. Flint Road is tertiary, and you'd likely agree that Service Center Road is less important than it. Thus, the unclassified tag makes sense here.

Sorry to have to revert some of your work here, but if you want to keep mapping, feel free to ask me for advice! I'd be happy to help.

-John
---

Published using OSMCha: https://osmcha.org/changesets/122232878

125758184 over 3 years ago

Hi,

Why did you remove the `source:population` tag? What's the source for your new data?

117534387 over 3 years ago

Reverted in changeset/125834870 . Please map in accordance with the NYS Classification Guidelines, which would make this part of NY-5S highway=primary with expressway=yes.
---

Published using OSMCha: https://osmcha.org/changesets/117534387

117533978 over 3 years ago

Reverted in changeset/125834870 . Please map in accordance with the NYS Classification Guidelines, which would make this part of NY-5S highway=primary with expressway=yes.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117533978

125547911 over 3 years ago

Reverted in changeset/125834666 . Please map in accordance with the NYS Classification Guidelines, which would make Lake Ontario State Parkway highway=primary with expressway=yes.