Hi Mateusz,

Good catch. I'm not sure what I was thinking when I added that, it should definitely be just motor_vehicle. Feel free to change it if you'd like.

Hi AlexMQ,

Great edit! I don't think there's any real criticism I can give, since everything is pretty spot-on, but there are a couple notes that I have.

First of all, for imagery, I see that you used Mapbox Satellite. In my experience, Mapbox tends to have the highest resolution, but is severely outdated (something like 10 years old I believe), and sometimes has issues with its projection (e.g. things appearing at an angle, bridges appear cut in two pieces). For this reason, I will sometimes use Mapbox as a secondary imagery source, but not without creating an offset to align it with my primary source, and verifying that nothing has changed too much in the area I'm mapping (since the imagery is old).

I tend to use NYS Orthos Online (called NYSDOP Orthoimagery in iD) as my main imagery, since it's provided by the state and they have a pretty good program. Unlike some other commercial imagery sources, this source is very consistent across the state. Bing is very good these days in cities, but in rural areas it can be really bad. Anyway, I'd recommend using NYS Orthos when it's good enough, but I will admit that its resolution isn't as good as others. When you need the extra resolution, I'd recommend trying Bing first, and then Mapbox, both with an offset to NYS Orthos if possible.

Another note I have is that in case you aren't using one already, there are plugins that automate the creation of grids like the parking spaces you added. I would highly recommend using them if you make more edits like this in the future, as they make the work dozens of times faster.

Also, try to specify your source for data beyond what is apparent from imagery. In JOSM, you can add this in the source box which by default just has your imagery used. Some common ones include "survey" (used by StreetComplete, generally considered to be the strongest source), "local knowledge" (for things where you might not have gone to the site and inspected closely, but you know about since you live in the area), or even just a link to the website that you found the information from. If you knew this information from local knowledge, you could format the source field as "Mapbox Satellite;local knowledge".

Anyway, great edit, thanks for putting so much thought into your work!

Best,
John

Hi,

You seem to have added wetlands around the water that was already there. You should probably use a multipolygon in this case so that the two features aren't layered on top of each other.

Hi, and welcome to OSM! Thanks for contributing.

Unfortunately, I had to revert the part of this changeset that worked on the intersection. Unless the roads can't be driven on, you should never leave them fragmented and disconnected like this. Even a rough guess is better than not mapping it at all.

If you're not sure how to map something, the wiki is a great place to look. You can also send me a message anytime if you're lost on something.

Thanks again for contributing!
-John

No worries, OSM is definitely the exception in this regard when compared to other maps. See here for more info: osm.wiki/Abbreviations

Hi,

It's been quite a while, so you may have figured this out already, but you shouldn't include abbreviations in street names like you've done here. Thanks for the contribution though; I'll fix it now.

Best,
John

Thanks for writing back so fast! I was able to fix it.

I do have a question about the road though: do the street signs actually say that this short segment is "Wilson Park Drive"? I see that it was newly built, relative to the rest of the street.

Hi,

Please make sure not to abbreviate when adding new road names. In this case, "Wilson Park Drive" would be correct, instead of "Wilson Park Dr".

Hi,

This is not the proper way to do this. Instead, this data should go in the destination tags of the motorway link.

In addition, the name tag is not used for this purpose in the United States. You should instead put this sort of things in the destionation=* tag. When tagging this way, the value of the tag should be exactly as it appears on the real exit sign, but with all abbreviations expanded. For example, if the exit sign said "Sunrise Hwy W", you should tag the motorway_link (not the motorway junction!!) with destination="Sunrise Highway West".

Addressed in changeset/130015631 .

Hi,

In this case especially, it's important to also add construction=path as well. Otherwise, it is unknown what type of highway is being constructed, and a lot of software will likely assume it's a highway for vehicle traffic.

Having the track number in railway:track_ref feels appropriate, as you've already done. Thanks for taking the time to work on all of this.

Thanks for the good edit! The names without MT* make for a more pleasant map.

Hi,

Overall this looks like a good changeset, but there were a couple things that caught my eye.

First of all, you should not add names like "NB Hutchinson Rvr Pkwy to WB Cross County Pkwy". The name tag is not a place to describe a feature, but rather it should be an objective, established name for it. Also, you used abbreviations in it, another thing that should not be done in name tags, barring very rare circumstances. Ideally, for features like this, it should have no name at all.

Also, it looks like you changed the value of "New York, Westchester and Boston Railway" from railway=razed to railway=abandoned. Why did you make this change? I don't think you'd be able to tell that there was a railroad there anymore, unless you had prior knowledge going in.
---

Published using OSMCha: https://osmcha.org/changesets/126300367

Hi,

This does not follow the current highway classification guidelines, so I've reverted this in changeset/129803211. I did keep the operator that you added to Phelps, though.

Please review the classification rules at: osm.wiki/TMP-Proposal:_New_York/Highway_Classification .

The most important thing in the new system is: trunk does not mean limited access, and limited access does not mean trunk. Use expressway=yes to denote limited-access construction instead. Alternatively, if the road has complete control-of-access and is high enough performance, highway=motorway might be suitable.

The idea behind the new classification system is that the network of all roads that are either motorway or trunk should be all of the most natural long-distance transportation arteries. Some roads might run long distances, but not be nearly as desirable for long distance (e.g. the nearby US-9). Roads like this should usually be highway=primary.

In this case, Phelps Way has intersections, which disqualifies it from being a motorway. It also isn't really useful for long-distance travel, as it would dump you into US-9 or other local roads. This disqualifies it from highway=trunk. The next classification down from there would be highway=primary, which I think is suitable for this road. Secondary seems too low, as it is a much more appealing east/west option than the other roads in the area (which are either tertiary or secondary).

I know that highway=trunk has historically been used for limited-access roads in the U.S., but we're trying to move towards a less fragmented and more usable map in terms of classifications. If you'd like to keep working on classifications, I would appreciate your help in moving the map in this direction as well. #local-newyorkstate on the OSMUS Slack is one place where people discuss classifications like this, and having your voice there would be great, if you'd like to join.

Sorry for the long read,
-John

Hi,

I feel that this sort of tagging isn't ideal. The name tag of an object is supposed to be the most natural way to refer to something in normal circumstances. If you were driving on this road (in the express lanes), and someone asked which road you were driving on, "Cross County Parkway" would probably be more natural than "Cross County Parkway Express Lanes".

This sort of information can be described in other tags. The most important one would probably be `destination` at the point that the express section begins. If memory serves me right, that's the only place that the word "express" is even used on the ground, so it might be most suitable to have that be the only place it's tagged as such.

I'll wait a couple days to hear back with your thoughts, but if I don't hear back I'll set it back to just "Cross County Parkway".

Best,
John

While it is true that it has those in some capacity along this length, it's generally not as performant of a road when compared to some others nearby (e.g. I-87 and the Sprain). The lanes are more narrow and the road is just harsher. On top of that, intersections start pretty close from here, so trunk +expressway=yes seemed most fitting.

As a local, I disagree. Have you driven on it?

Hi,

Why did you do this?