OpenStreetMap logo OpenStreetMap

Changeset When Comment
126635561 about 3 years ago

Hi pabi12, this is another case where the entire building is not the poi so its best to place the poi in a node instead and leave the building as is since there are apartments in the floors above the restaurant. I have fixed this case on the map for you.

126634993 about 3 years ago

Hi pabi12, this changeset as well as a lot of your others in this area I see that you are merging node pois with buildings but in most of the cases I see, the buildings do not only contain the poi, rather the buildings have apartments in the upper floors etc so its best to leave the poi as a node instead of merging it with the building since the building contains more than just the one poi - also the building is not named after the poi... I have made the correction on the map but please in future edits note this important distinction to avoid these types of edits. If the poi inside a building is not the entire building then leave the poi as a node outside of the building itself.

126795363 about 3 years ago

thanks for the suggestion! I just updated it.

126484324 about 3 years ago

thanks for the information, yes it looks like thats the case. I just updated it to reflect the two entities. thanks!

122885486 over 3 years ago

Hi anon950, thank you for your edits! Just wanted to point out to make sure when you are making edits to existing features on the map that you make sure to check to see if any existing tags to the feature are still relevant so you dont inadvertently remove tags when making edits. For example, your edit to the Nightingale Apartments, looks like you forgot to transfer over the building:levels=6 tag from the existing feature to your new one. I have already fixed this but just double check things in the future. Also could just edit the existing feature instead of deleting and adding a new one to make your edit would be another way to ensure you dont inadvertently remove tags and helps preserve the change history of a feature.

123331822 over 3 years ago

Thanks ZLima12, great update on the names that looks good to me. Ive seen it like this for other universities that have multiple disparate campus areas but are administered as one larger university entity but open to ideas on the multipolygon concept.

99781704 over 3 years ago

thats a good question, the studio map didnt make it clear either way only the label on the building was the number. I know other studio lots tend to just name buildings like: "Building 1230" etc but unclear how they are doing it here. The numbers are all unique and dont repeat which makes me assume its a building number instead of an address based on a street but certainly it could what you suggest as well. Feel free to make updates if you think its an addr number.

122092788 over 3 years ago

Hi thirashima, thanks for updating closed pois. For pois that are now empty, you can mark the amenity as disused using this: disused:amenity=restaurant which follows the schema here: disused=*: instead of changing the name tag to 'closed'. Otherwise your change is saying this restaurant is still open and its name is now called "closed" which I dont think is what you meant to do.

121637229 over 3 years ago

Hi tbo47! Thanks for updating pois that are no longer open. Just a quick question, for cases where some of the poi attributes are still valid such as in this case the address for this now empty restaurant, it would be helpful to leave the tags on the poi that are still relevant and just remove the ones that are no longer relevant instead of deleting the whole thing. So here you could keep all the address tags and even the amenity tag and set it to disused:amenity=restaurant. This also helps keep the history of this location intact. what do you think?

121551123 over 3 years ago

Hi AmpereBEEP, thanks for adding this proposed railway. Since it does not yet exist nor is it under construction yet I suggest you also add the 'proposed' tags to it to follow the osm schema here: proposed=* and here: osm.wiki/Lifecycle_prefix

111918462 over 3 years ago

Hi jmapb, if I remember correctly it was originally a multipolygon with Building B and when I separated them into distinct structures I must have left the multipolygon tag on Building A by mistake. So no real reason for it it can be updated to a normal building if you like.

119933742 over 3 years ago

I went ahead and made the tag updates to follow the schema for pylon and adjusted the outline the best I could as it was based on the shadow before. I hope this is better but Ill defer to you on any further adjustments or if you want to keep it or not. Feel free to modify.

119933742 over 3 years ago

Hi Adamant1, thanks for checking that after looking again I agree with you bridge:support=yes may not be the best tag there. Looks like bridge:support=pylon via bridge:support=pylon would actually be the best tag here and it supports the use of the building tag but the building tag should be building=service. What do you think? If you agree I can make the change no problem otherwise if you would rather not have it mapped at all Ill defer to you it ok with me either way.

119277134 over 3 years ago

Hi impiaaa, thank you so much for your catch there, I mistakenly forgot to keep that info there, I missed it in the relation. I have just put those tags back and updated that building wall section as you mentioned here: changeset/119307898. Sorry about that. I agree there are better tools out there for splitting existing areas, Ill keep that in mind next time.

107609061 about 4 years ago

Thanks wireguy, I think I have fixed it by changing the relation type to site: changeset/114674392 I hope that solves the issue.

111782587 about 4 years ago

Thanks MxxCon I saw your solution in your changeset, that looks good. Thanks!

111782587 about 4 years ago

Hi MxxCon,
Based on the official facility map these buildings are listed as "Pier # Cargo Shed" map can be found here: https://www.panynj.gov/content/dam/port/customer-library-pdfs/facilities-map.pdf however I am sure there are specific warehouse/container businesses operating out of them that could be added as nodes. I agree the names seem pretty general... I could make them a note tag instead, open to suggestions...

107582816 over 4 years ago

Hello! Just wanted to mention that I think the church you added here: way/962343223 seems to map the square area for the church as a building but really the building is a different structure inside of the square and is much smaller. Id suggest removing the building=yes tag from the polygon and then if you still wanted to add the building, to add the building using the building footprint in the imagery that is inside of the square. Otherwise you could just change the square polygon to fit the actual church building footprint instead and that would solve it too.

88798810 over 4 years ago

Hello it looks like this changeset added building outlines on top of existing outlines, now there are many duplicate building outlines that all overlap. Is there a plan in place to fix those and remove the overlaps?

104922080 over 4 years ago

I went ahead and corrected the name on the poi for Riley_Andersen, it looks like it also needed an amenity tag. Funny enough via a google search it looks like Riley_Andersen tagged this poi for the house of the main character in Inside Out... regardless it still should not be tagged as such...