Frank Peng's Comments
| Changeset | When | Comment |
|---|---|---|
| 174866226 | 23 days ago | Or maybe you were meant to tag this road as a foot path or something else? |
| 174866226 | 23 days ago | Why is there a road going through a school building and past a football field? I do not see a road going through these in the aerial imagery. What is the source for the addition of this road? Did the road recently get added here on the ground? Thanks. |
| 174860743 | 23 days ago | Can you explain why you tagged a city (or town) boundary line as a road in this changeset? I do not see a road lining the city boundary line in the aerial imagery. Are you trying to map for the renderer? If so, then please note that it is not good practice on OSM. Don't incorrectly tag valid map data or add incorrect data to OSM just because you want it to show up in the map renderer of your choice or to make it look prettier. Map or tag things as they are on the ground. See osm.wiki/Tagging_for_the_renderer |
| 175070230 | 23 days ago | Hello TransAct-AS, can you explain why you tagged way/845861056 (way/845861056) as an unclassified road again? I talked to you about this (See changeset/174652113). You also tagged a section of Lakeview Road as an unclassified road (way/179349942). Can you explain the reason for this change? Thanks. |
| 175006399 | 28 days ago | Thanks for the fix! Don't know how the Virginia Tech university boundary was broken, but thanks. |
| 131986382 | 28 days ago | This changeset has been reverted in changeset/174973672. |
| 128368704 | about 1 month ago | This changeset has been reverted in changeset/174967866. See changeset comment in changeset/174967866 |
| 174889797 | about 1 month ago | Forgot to add this in the changeset comment:
Correct changeset comment:
|
| 174445668 | about 1 month ago | User TransAct-AS tagged way/845861056 as a primary road in changeset/173929308 (changeset/173929308). I removed the "highway=primary" tag from the way in changeset/174636140 (changeset/174636140). I forgot to add this in my previous comment in this changeset discussion. |
| 174445668 | about 1 month ago | This mistakenly deleted way (way/845861056) incorrectly tagged as a primary road, that appears to be a suburb line for Northlake, Charlotte, NC, reverted in changeset/174635876 (changeset/174635876).
|
| 174652113 | about 1 month ago | As stated previously, it appears that you were trying to map for the renderer, which is not good practice on OSM. Please let me know if this was not the case. I just want to make sure that you're following good practice on OSM. osm.wiki/Good_practice |
| 174652113 | about 1 month ago | Can you explain why you tagged way/845861056 (way/845861056) as a primary road at first then as an unclassified road? way/845861056 is a suburb line for Northlake, Charlotte, NC. Please don't mistag features on OSM. |
| 174652113 | about 1 month ago | Hey TransAct-AS, I see that you mistagged way/845861056 again, this time as an unclassified road. It appears that you were trying to map for the renderer, which is not good practice on OSM. Just because a borough or suburb line doesn't show on the map doesn't mean you can mistag it as a road or another feature just so it will show up on the map in your renderer of choice. Per the OSM Wiki, it states: >"Draw things as they are on the ground. Do not enter incorrect data or remove correct data just because it will help a map renderer, a navigation system or some other data consumer which has problems with the correct data. They are continually improving, don't bend the data to make it look prettier, just be patient, try a different data consumer or report the issue to the data consumer it concerns"
osm.wiki/Tagging_for_the_renderer As a result of you mistagging the suburb line (way/845861056), you created on overlapping highway issue. The issue that you created has since been resolved by another mapper in changeset/174702103. In the future, please don't mistag borough or suburb lines as roads or other features just so it will show up on the map in your renderer of choice or to make the map look prettier. Draw or tag things as they are on the ground. |
| 162034767 | about 1 month ago | Please be aware of the "lanes=*" and "turn:lanes=*" tags on the Patton Drive ways. In this changeset, you merged Patton Drive way/221424565 (way/221424565) tagged with "lanes=2" with its adjoining Patton Drive way (way/1153637286 way/1153637286) tagged with "lanes=3", resulting in a single way from the Walmart parking lot to North Franklin Street. The "lanes=*" tag indicates the number of lanes on a road. For Patton Drive from the Walmart parking lot to North Franklin Street, it starts as two lanes and changes to three lanes coming up at the North Franklin Street/Patton Drive/Laurel Street intersection, as clearly seen in the aerial imagery. Patton Drive way/221424565 tagged with "lanes=2" corresponds to the two-lane section, and Patton Drive way/1153637286 tagged with "lanes=3" and "turn:lanes=left|left;through|right" corresponds to the three-lane section and the turn lanes. For the Patton Drive turn lanes coming up to North Franklin Street, the left lane is a left-turn lane, the center lane is a shared left and through lane, and the right lane is a right-turn lane. It would have been better to leave the Patton Drive way tagged with "lanes=2" (way/221424565) on the map instead of merging it with its adjoining way with the same name. I would encourage you to read these OSM Wiki articles on lanes and turn lanes tagging, so this is brought to your attention to keep in mind for the future:
|
| 173929308 | about 1 month ago | Just to follow up, what do you mean by this changeset's comment "connect features"? Were you trying to connect any features? If so, which ones were you trying to connect? |
| 173291613 | about 1 month ago | What do you mean by "no restriction"? In this changeset, you removed a way from the Northlake suburb relation. The way that you removed from the relation appears to be a suburb line for Northlake, Charlotte, NC. |
| 161805877 | about 1 month ago | The Sycamore Street Northeast way tagged with "lanes=4" that you merged with the other way of the same name in this changeset has been restored in changeset/174623996. For future reference, see these OSM Wiki articles on lanes and turn lanes tagging:
|
| 133313065 | about 2 months ago | An FYI, you don't need to delete existing landuse or multipolygons if they reflect what is actually seen on the ground, and then redrawing them anew. It's better to leave them on the map and adjust their geometry. In this changeset, you deleted a school multipolygon and then redrew the school area. The school multipolygon that you deleted was valid and actually reflected the Christiansburg High School area in aerial imagery. It would have been better to leave the school multipolygon on the map and update its geometry or add/change tags if necessary. You also deleted a residential multipolygon in this changeset. The residential multipolygon that you deleted actually reflected the residential area(s) seen in aerial imagery. The residential multipolygon didn't have to be deleted. You just have to adjust their geometry by adding nodes to the multipolygon or moving their nodes. Make sure to help preserve the history on OSM by modifying existing elements instead of deleting them and redrawing them from scratch. Per the OSM Wiki, it states: "When things change in the real world, be bold, and edit the map to reflect the current situation. But be aware that OpenStreetMap can store the editing history of an element. You can help preserve this history by modifying the existing elements instead of deleting them and redrawing from scratch."
And also, "Be brave in what you add but careful in what you delete." i.e., not removing valid, in-scope detail from the map.
|
| 161805877 | about 2 months ago | Just to follow up, you can read this OSM Wiki article about keeping the history: osm.wiki/Keep_the_history, so this is brought to your attention to keep in mind for the future.
Instead of deleting elements such as roads, buildings, or landuse and redrawing them, it's better to update the geometry of the existing objects, which retains their editing history. You don't need to delete existing roads or parking areas on the map and redraw them. Just update their geometry. Per the wiki, it states:
|
| 161807846 | about 2 months ago | You can learn more about the placement of the OSM-way in this OSM Wiki article so this is brought to your attention to keep in mind for the future: osm.wiki/Proposal:Placement |