CjMalone's Comments
| Changeset | When | Comment |
|---|---|---|
| 114739207 | about 4 years ago | I just fixed your last one. Can you at least try to map it right. |
| 114196037 | about 4 years ago | Hey, just a heads up house numbers go in `addr:housenumber` not `name`. Fixed in #114315238 |
| 114114769 | about 4 years ago | Hey, We call this "mapping for the renderer" and we don't do it. OSM should be as correct as possible, it's the tooling that creates the maps that should be making it pretty. I've readded the name in #114315059 |
| 113455046 | about 4 years ago | Looks good, thank you |
| 113481454 | about 4 years ago | I saw some of your work in Treharris when I was mapping individual properties. Your buildings made that job much easier, thank you. |
| 113505168 | about 4 years ago | Cleaned up in #113543554. Address nodes shouldn't be on the way. |
| 112766448 | about 4 years ago | Cleaned up in #113543554 |
| 113481454 | about 4 years ago | Thanks for this, it looks good! I've been remote mapping Merthyr Tydfil for a couple of weeks now, good to see somebody local also contributing. :) |
| 112040926 | about 4 years ago | Are you sure this is an Aldi?
way/853037363
|
| 112839818 | about 4 years ago | Yeah, I made that tile server. Run dataset through ogr2ogr to fix the projection locally. Something like:
If you don't have QGIS installed you can get OSTN15_NTv2_OSGBtoETRS.gsb from https://www.ordnancesurvey.co.uk/business-government/tools-support/os-net/for-developers |
| 112839818 | about 4 years ago | Just a heads up, if you are gonna work with this dataset you need to project it properly. Aligning to it with JOSM bad projection isn't going to help. way/995571275
|
| 112923147 | about 4 years ago | Nice one, I extended the sidewalk to a more accurate point, I guess that's what caused this. Kinda surprised JOSM didn't warn me about it. |
| 112940327 | about 4 years ago | I requested a review on this because it's my first time doing public transit routes. I now think my refs on the routes should have been just "27" not "Me27-x", but not that confidant on that. |
| 112694411 | about 4 years ago | It's fairly easy to find all the building=terrace with you as the last editor. https://overpass-turbo.eu/s/1cds You could then load that into JOSM (I don't think iD will be able to handle it) and do a bulk edit. Or I could do that if you wanted. But I don't know if it's that necessary, maybe leave them and just try to stick to building=house in new traces, or when you come across them. |
| 112694411 | about 4 years ago | Hey, it looks like you are using building=terrace on the individual houses in a terrace. The wiki describes it the other way, building=terrace is for a large building with mulitple houses, if you're gonna split each house they just become building=house. |
| 112501822 | about 4 years ago | Thanks, fixed in #112536091 |
| 112407715 | about 4 years ago | It was actually June, NSUL 2021-06. |
| 112270604 | about 4 years ago | I've got a few ideas on how we could make adding postcodes and UPRNs from NSUL more efficient. If I ever get around to it, I'll let you know. |
| 112270604 | about 4 years ago | I've written a quick script to query the FHRS API and format it into GeoJSON to be loaded into JOSM and worked with. (I've now fixed it to try and fix postcodes, or warn me.) Do you have any tooling to help you work with NSUL? Or are you just using the tile layer? |
| 112270604 | about 4 years ago | Nice one, your right was just trusting the source data in this instance. Another one that has caught me out when actually parsing postcodes is "AA1 OAA" instead of "AA1 0AA", it's actually a pretty common typeo. |