OpenStreetMap logo OpenStreetMap

Changeset When Comment
148663376 4 days ago

Think this sorts them all out: changeset/176203918

148663376 4 days ago

Hi! And thanks.
shop=storage_rental is fine as that better aligns with current use.

A mass edit would be safe, but there may be no need - I can see on Overpass I've used this tag about a dozen times and see other small fixes I'd like to make at each location. I'm reviewing now for cleanup.

SOAPBOX
shop=storage_rental is weird though. I keep accidentally using amenity because it makes more taxonomic sense in my brain. Even when you poll https://taginfo.openstreetmap.org/search?q=shop%3D*_rental vs https://taginfo.openstreetmap.org/search?q=amenity%3D*_rental, it is an outlier.

This specific location rents storage, trailers, and trucks, and also sells moving supplies. I'd love to have an agreed tag block that covers these appropriately.

/SOAPBOX

154793219 15 days ago

Hi! Thanks as always, should not be garden and will fix shortly.

To be sure, are you aware of any better fit for a business that only sells dirt, soil and groundcovers? There are several similar such places around this area.

I'm tempted to try shop=agrarian with maybe... agrarian=landscaping? Only trouble is that I can't seem to pin any good examples.

155386239 24 days ago

Hi! Thanks, this is a fun one. shop=lawn_mower_repair seems best - far as I recall that's all they do.

I've already updated the tag and will also resurvey when in the area again.

174969044 about 1 month ago

Oops I meant City of Mountain Park, not Hickory Park. :-)

167028001 7 months ago

Hello SrinivasK280902,

Thank you for your contributions here. A number of the changes made to these skyways/pedways in this changeset are not quite correct for their use case.

The tag `layer=1` should be added back as they are all several stories above their respective roads/ways.

The endpoints where they connect are buildings/structures and are not crossings. `entrance=yes` tags should be added back and crossings removed.

`indoor=yes` was removed in at least one change when most of the ways are technically indoors (and more `indoor=yes` would be appropriate).

Removing surfaces is likely correct here as it looks like these were tagged for their roof surface where the walking surface would be more applicable (but harder to know).

Changing `highway=footway->pedestrian` is debatable. A review of the wiki would suggest that pedestrian is a bit more applicable to larger open areas. I am unsure what what `pedestrian` adds over current. osm.wiki/Tag%3Ahighway%3Dpedestrian

Thanks,

166632833 7 months ago

Hi SrinivasK280902, thank you for your contributions to OpenStreetMap, as well as for reaching out and requesting review. I have some questions/comments regarding parts of this changeset.

First, you might review comments I recently left for another user editing nearby as they apply here too: changeset/166587809#c1440123. In there I note:

- use of `wheelchair=unknown` is generally discouraged.
- Removal of generally valid `kerb` tags.
- Addition of `highway=crossing` in incorrect places.

There appear to be the removal of a number of valid driveways/crossings. Also, tags for the Equitable building were moved into a nearby way as a relation - the tagged information is still there, but the building itself is now gone.

Overall, I don't think a number of these changes fit common mapping practice, but with some time and the support of the OSM community, we can likely make fast and supportive improvement.

You mention PIDA in your changeset comments. Might that refer to "Pedestrian Infrastructure in Downtown Atlanta"? If you are part of a team/project, I highly recommend reaching out to the OSM community. Not only can we provide support, advice, and tooling, we may able to directly aid your project initiatives. You can find some community links here: https://openstreetmap.us/about/contact/, including a link to our OSM US Slack, where I usually am.

Thanks!

166587809 7 months ago

Hi MihanJhaveri, thank you for your contributions to OpenStreetMap. I have some questions/comments regarding parts of this changeset.

I see you removed some service roads. Has something changed on the ground that is not reflected in recent imagery? If service access is still there but not publicly accessible, you might consider adding "access=private" to the way, rather than deleting. Adding a known service, such as "driveway" or "parking_aisle" can also be helpful.

There are a number of places where you are adding "wheelchair=unknown" to footways. As described in the wiki, "wheelchair" tags are most useful when backed by a strong source of truth, such as a nearby sign or personal experience. A value of "unknown" is not common or encouraged. wheelchair=*

The above change also often removing "kerb", kerb descriptors, and "tactile_paving" tags. Fixing or removing these are fine if erroneous or if ground truth differs from imagery, however, broadly changing correct tags without backing support is generally discouraged.

Some changes are also adding "highway=crossing" to a node where a footway and crossing meet. This tag is better placed where crossings and highways meet - there are examples in this changeset (which incidentally have been marked as "crossing=uncontrolled" when there are "traffic_lights").

Some of your edits, like this one... are great! way/1388652526.

It can take some time to get familiarized with common mapping practices. I am happy to answer questions, and we have a number of community forums and resources to help as well: https://openstreetmap.us/about/contact/.

Thanks!

163481876 8 months ago

My oops, now fixed, thanks!

140916058 8 months ago

(and thanks!)

140916058 8 months ago

Huh, odd, I have no idea how I added this as fixme in the first place. I will update this shortly with appropriate values.

159671066 about 1 year ago

Changeset title intended here to be "Hospital Updates, Winship Cancer Institute, Linden Avenue Northeast, Fulton, GA, US", but my keyboard got stuck in JOSM for some reason and refused to type/paste.

157232218 about 1 year ago

Tag shop=e-cigarette is indeed the appropriate tag for this. I will update shortly, thank you for catching!