nmombo12's Comments
| Changeset | When | Comment |
|---|---|---|
| 116682069 | almost 4 years ago | Ah, that must be some nice imagery! My concern wasn't so much about the API key (which now that you mention should not be public), but the license compatibility. From the NearMap wiki page, edits which use NearMap aren't permitted even if you have paid for access to view the imagery. "In June 2011, Ben Last of NearMap clarified that the new OpenStreetMap license would not be compatible with the CC-BY-SA style license under which data can be derived from NearMap PhotoMaps. Use of Nearmap aerial imagery as a source for OpenStreetMap was permitted by NearMap until 17 June 2011, and Nearmap agreed that existing derived data could remain in the OpenStreetMap database post-license change." Unfortunately, I do not think OSM can keep this edit due to the license. I'm not sure how we handle this unintentional license issue. I'm going to ask in the slack and see if we need to involve the data working group or just revert the edit. |
| 116682069 | almost 4 years ago | Thanks for contributing! What kind of imagery is this nearmap source that you're using? |
| 116677277 | almost 4 years ago | Thanks for your contribution, welcome!
|
| 116703367 | almost 4 years ago | Hi! Thanks for contributing. I'd like to suggest a change to the opening hours format to match the wiki. Here is the page with examples. opening_hours=*. In this case, I've formatted it for you to edit. Mo 08:00-19:00; Tu 08:00-17:00; We,Th 08:00-18:00; Fr 08:00-14:00; Sa 08:00-13:00 Second, the description key should not be used for advertising. It is encouraged to add your business to OSM, but the description should be limited to information that can aid other mappers or provide detail to an end user. Here is the wiki for the description key.
|
| 116112262 | almost 4 years ago | Reviewed, looks good to me. Thanks for contributing!
|
| 116114551 | almost 4 years ago | I didn't see this changeset until I had already commented on your other changesets. So this may be a little repetitive. Welcome and thanks for your contribution! I have reviewed this changeset and it looks good. My only suggestion is that instead of a unit conversion from ft to m for width check out this link for how to use feet and inches. width=*
|
| 116120262 | almost 4 years ago | Is the width with four decimal places the result of a unit conversion? I believe you can use an apostrophe to use feet and inches.
|
| 116120517 | almost 4 years ago | Welcome and thanks for your contribution! |
| 116069875 | almost 4 years ago | Great, thank you!
|
| 116069875 | almost 4 years ago | Where did you find information on the license for the MDNR GIS data? When I last accessed the Michigan GIS portal the license for the imagery I was looking at was incompatible, but that was a while ago. I'm interested to see what's changed since then, if some subsections have compatible licenses, or whatever else makes this possible. Thanks!
|
| 115860105 | almost 4 years ago | Hello Venom, thanks for your contribution. Fairways with "cutouts" for bunkers, mounds, etc. should be mapped as multipolygons. Here are some references with examples.
|
| 115861881 | almost 4 years ago | Hello jaywhyenecks, thank you for your contributions to OSM. My assumption for this changeset is that you are making this edit for use with the TGC-Designer-Tools utility for the PGA Tour 2K video games. If so, it is not accepted to intentionally map features that do not exist in the real world for this purpose. It is just like "mapping for the renderer", in this case the renderer is TGC-Designer-Tools utility. osm.wiki/Tagging_for_the_renderer
|
| 115838336 | almost 4 years ago | Hi Chris! Thanks for your contribution. You might be interested in coordinating with Steve (user c0nsumer) who added the Royal Oak bike network in the fall of 2021. Perhaps there is some benefit to be had with combining efforts of mapping Oakland County bike routes.
-Noah |
| 115578514 | almost 4 years ago | Apologies for the large changeset area. I must not have finished uploading before traveling. |
| 113943384 | almost 4 years ago | Hello! The description key should not be used for advertising. It is encouraged to add your business to OSM, but the description should be limited to information that can aid other mappers or provide detail to an end user. Here is the wiki for the description key. description=*
Updated in changeset/115716221
|
| 115219591 | about 4 years ago | Just checked out your new changeset. Looks good. When the fairway goes all the way around you could use just keep it as-is or optionally use a multipolygon. Thanks! |
| 115219591 | about 4 years ago | Hello ICU812, thanks for your contribution. Please check out this reference guide for the fairway-green intersection. The fairway should share nodes with the green and not overlap.
|
| 115132471 | about 4 years ago | Hello Don, thanks for your contribution. I have a few notes on this changeset. Fairways with "cutouts" for bunkers, mounds, etc. should be mapped as multipolygons. Here are some references with examples.
Connected waterways should be a single combined way instead of separate overlapping ways (way/1013528655). I can make these suggested updates at this golf course today, so by tomorrow you can use some of these updates as a reference for the future. Please let me know if you have any questions.
|
| 115214672 | about 4 years ago | Typo, should be Orchard Grove*** |
| 115175784 | about 4 years ago | Great, thank you! |