fghj753's Comments
| Changeset | When | Comment |
|---|---|---|
| 126138420 | over 3 years ago | P.P.S @waterproof_19m, ma ei olegi varem EHRist geomeetria importimisele mõelnud, paistab, et nad kasutavad hoone kujude jaoks teistsugust allikat kui Maa-amet. (või on ministeeriumite ühishoone geomeetria registris lihtsalt vigane) |
| 126138420 | over 3 years ago | Warning: very long message. You can just copy this message to Word to make reading it more bearable. Tere, First off, let's start with a brief overview of history. When i became OSM mapper, there was an active building import by SviMik that was focusing on adding new buildings from Maa-amet (MA from now on). SviMik had a policy, that to avoid possible editing conflict (conflict as overwriting someone's work without their consent), his bot would only either add new buildings or update addresses on buildings last edited by selected users/bots (mostly large volume users such as Verbatium, xybot and juhanjuku). At same time buildings added by his MA imports had very high data quality. Because of trying to not interfere with possible future imports, I'm still not really proficient at mapping buildings. Collection of some resources regarding to SviMik's import.
Importing new buildings as outlines is not really difficult per se, just download ETAK data shapefile from MA and upload them with Josm. Problem here is the OSM's expectations for quality. For example, the most obvious step is adding tags that are suitable for OSM object and not uploading buildings that are already added to OSM. However, there are more nuances which reveal themselves after you have decided to start this process. In Estonian context, MA's geometry data is sometimes too high quality for modern OSM expectations (e.g having 40+ nodes per circular way while OSM standard is 20) or has minor artefacts caused by technical limitations of their internal software (complex issue, but it results in too many nodes on a straight line). Those were just issues i had with geometry import. Another dimension is getting the address data right. My import focused only on geometry, because tags were already updated by SviMik's import in 2019. However, i noticed that address field in the dataset was just single text field - it would be really difficult to try to generate address tags from this field. More reliable source might be MA's ADS (aadressiandmed), but since that's not downloadable, just an API, then i believe using it would quickly become bottleneck for the import process. SviMik's source code for import bots is not public, mine is indeed on github repo linked above.
My import on wiki - osm.wiki/Maa-amet_building_geometry_update
Replying to qqqqqqqqqqqqqqqqqqqq's questions:
P.S I was told this comment should be a wiki page. Problem is that I'm replying to your discussion too directly, so converting it to wiki page will require lot of editing. |
| 82460204 | over 3 years ago | Once upon a time i was taught that cyclist can't ride on the street if there is designated cycleway next to it. Double checked traffic laws and streetlevel imagery - Yes, those restrictions can be removed. |
| 117835146 | almost 4 years ago | PPS. You have previously mentioned you don't write neither reasonable changeset comments nor split changesets into smaller regions because you don't have time. However, this changeset is part of series of 17 changesets made in 2 hours. I think making two changesets, one for eastern and other for western hemisphere and including adequate changeset comments could have actually been faster than your current process. |
| 117835146 | almost 4 years ago | I'd also like to point out language use of this changeset comment. This appears to be global changeset made by russian-speaking user (see created_by value) making changes mostly in Russia (see modified objects list), yet comment on this chset is in German. Dear iWowik, what is this changeset's connection to Germany? Why is changeset comment in German, not English or Russian? PS. According to https://resultmaps.neis-one.org/osm-discussion-comments?user=iWowik , the user has been notified and confirmed receiving the information about large changesets and changesets comments since April 2021. |
| 117768233 | almost 4 years ago | Tere, Priit.
|
| 116138570 | almost 4 years ago | @SimonPoole That's pretty much default behaviour in Josm - if you use click-and-drag method for selection tool, then it will select all nodes and ways within area by default.
|
| 115769750 | almost 4 years ago | Dear Mr/Mrs McBlyat, Judging by the lack of any further complaints I presume reboot has resolved the issue. All the best, Fghj753 |
| 115769750 | almost 4 years ago | Dear Mr/Mrs McBlyat, I'm sorry to hear about difficulties you are experiencing with using changeset visualization tools. That software can be highly overwhelming for a person who has just joined the OSM community. Sadly I was not able to replicate issue you were describing on some of the most common tools.
Best regards, Fghj753 |
| 115775114 | almost 4 years ago | Nicely done, welcome to OSM!
|
| 115757708 | almost 4 years ago | Typo in ch.set comment: inction -> junction |
| 115384579 | almost 4 years ago | Forgot to mention in description, but i also removed approx. 5000 nodes from ways with over 100 nodes, where gap between two nodes was less than 30 cm. |
| 115127374 | about 4 years ago | Sorry, it was supposed to be two changesets: one in North-Columbia & West-Venezuela and other around Ecuador, but I forgot to check if previous changeset was closed and accidentally uploaded new changes to already open changeset. |
| 115042942 | about 4 years ago | Please consider keeping consecutive changes to same area in same changeset. Looks like changesets 115042339, 115042818 and 115042942 could all have been in single changeset. |
| 113951560 | about 4 years ago | Correction: Mixed up east and west: this changeset applies to SW, not east. |
| 113945723 | about 4 years ago | Correction: Mixed up east and west: this changeset applies to NE/SE, not west |
| 113326292 | about 4 years ago | Dear Mr/Mrs Grin, As you may have noticed by now, making large changesets in OSM attracts angry comments made by mappers, who are demanding you to create changesets with smaller bounding boxes. Such mappers are often located in Western and/or Central Europe. Therefore i agree with Gurgly Pipe on the matter that either size or positioning of your changeset is not optimal considering it's content and advise you to split future changesets bit smaller. As a user from rather small country, i strongly disagree with suggestion of splitting changesets by country's borders, because in Europe such actions could lead to unreasonably small changesets (often 1-3 changes per country). Instead, i would suggest splitting changesets by continents while keeping in mind mapper density (latter means splitting Western Europe). For example in your case there could be 3 changesets: changes in Usa, southern hemisphere (incl Vietnam) and in Europe. As for other two users. I have noticed under different global changesets, how some people (not necessarily you, don't take this personally) have voiced complaints over too large changesets breaking their review workflow. I would like to hereby encourage you to refrain yourself from such retroactive behaviour and focus on being proactive instead. If you are using a review tool that doesn't open large changesets, what is long-term benefit of announcing it in most changeset discussions? Why not think ahead and address the cause (tool doesn't support large changesets) instead of effect (tool crashes when opening large changeset)? Presuming the tool used is open source, please do open a pull request or at least issue on on tool's git/website and at least attempt to fix the bug yourself.
|
| 113187913 | about 4 years ago | Tere,
|
| 110714281 | about 4 years ago | I had a chance to drive past there today and stopped at parking lot for survey. Well, actually there's no signs about being a parking lot. Put together quick drawing of possible osm features. https://cdn.discordapp.com/attachments/537315188039221301/892523230919786496/parnamae-narva.png
I think Linnuse tee (way/129226648) should be mapped as residential road, but since it's dead-end road, there's no point in adding complicated access restriction tags. |
| 110714281 | about 4 years ago | Current state of Linnuse tee is tagged as cycleway with
* Turning right from Narva mnt to Linnuse tee is allowed as per destination sign on https://www.mapillary.com/app/?pKey=1001641713992040
No idea if caused by this changeset, but node/633025611 may need fixing as well. I am not sure if it has tactile paving though. Looks like non-standard rumble strip. PS. This junction was recently redrawn on OSM and anyone fixing this may encounter inconsistent relations or lanewise tagging. |