Hi Lake S, do you have local knowledge on this particular school? It looks like covered breezeways(walkways) connected the outer buildings to the large center building. If that's the case, they shouldn't all be drawn together with a single line, but instead be left as separate buildings. (There is probably a way to map the covered walkways as well, but I'm not too familiar with it.)

BTW, I was impressed with a high schooler having so many edits on OSM. Congrats and good luck with your future engineering plans.

Were you able to use satellite imagery for this or were you just guessing? The imagery I looked at shows just the start of the construction, but it is rotated about 30 degrees from your outlines. The buildings are mostly North/South.

Hi CoasterRoyalty, first off, thanks for helping to enhance OSM. I'll be the first to admit that I don't know about mapping golf courses specifically, but I'm seeing some potential problems and wanted to reach out to you and see what's up. The first problem is that you have several areas of the same type that are overlapping. For example:
way/684203341, way/684203340, and way/684203344 are all overlapping and are marked as "golf=rough". Is there a reason that these aren't all drawn as one large area instead?

Second, is a little more complex and might be too much for a new mapper to tackle, but something to keep in the back of your mind. You have an area drawn as golf=rough, and then inside that you have another area drawn as golf=fairway. The outer area says that everything inside of it is rough. But then the inner area now implies that it is *both* rough and fairway. The advanced feature to handle this is called a multipolygon. Something to look into if you're bored and want to expand your mapping abilities.

You added an email address instead of a website. Was that intentional? There is an "email" key that you can use instead of "website". See email=* for more information.

Hi @reidpelton. I wouldn't be so quick to blame yourself. Maybe it was the tooling that created the problem.

I'm not sure which other ways of yours I've corrected. I'd happily go over them and see if I can make it clear what I fixed.

For this particular one, use this tool (https://overpass-api.de/achavi/?changeset=69609760) and zoom into West Karcher Road and Caldwell Boulevard. You'll see a red line that is what I deleted in my change. Looks like somehow the way deviated out to that stoplight in the middle of the road and then back to its original path. It looks like that node was always part of the way, but whatever alignment change you made to it caused it to show up on a report I look at often.

Hope that helps. Again, let me know if there are others you want me to look into.

b-jazz

Hi @tompkinsjs. I noticed that your recent edit of way/549172718 messed up the scrub multipolygon and thought you might want to go back and fix it up properly.

Hi @chachafish. I see there are a lot of duplicated nodes (two nodes in different ways that share the same exact location) after you are done squaring buildings. I'm surprised since JOSM has a validation for this, but maybe your workflow is somehow skipping that validation.

A couple of example nodes in case you need to look into it:
node/1613620267
and
node/1613621632

They are showing up in OSM Inspector if that helps discover which ones are duplicated.

Thanks!

By "highway network" he means you have to be able to get from the nearest road into the parking lot. For example, "Honey Creek Drive" is tagged as "highway=residential". Just make sure it is connected to something like that. Don't think of highway being a 4 lane interstate highway. In OSM terms, roads are all highways, just of different types.

Looks like I did the Northeastern parking lot from this changeset as an example to show you how it should be done. But I left the rest hoping you would go back and practice.

Hi Borishman, welcome to OSM. I noticed that the way for the golf club (way/683470873) makes two laps around the golf club. There should only be a single boundary in order to draw the area. Can you remove one of the two loops? Thanks.

Hi TOGA,
way/21453053 is now crossing back over itself on the southern end, which is considered bad mapping practice. Is there something you can do to make sure this doesn't happen? Thanks.

If the site can not do https, or doesn’t want to use https, this change wouldn’t have been made. These changes are only done to sites that actively announce their desire for clients to talk to them on port 443.

I found four other "rooms" with the same shape:

way/675236765
way/675236761
way/675236753
way/675236751

Did you want to correct or delete those?

I agree with your second statement.

Ah! That makes a lot more sense. Thanks @trigpoint.

Thanks for the info DaveF. I was unaware that this was valid information. What software turns those into clickable links? I'll happy correct them to be valid in the future. As for adding them to the bot, I want to keep the bot focused on it's agreed on task. I correct oddities that I see by hand since they are relatively rare.

I’m not familiar with openlevelup. There are a couple more issues that I’ve noticed with the indoor mapping. I could let you know when I return to my desktop if that helps.

Hi F4sOWRt, thanks for your contributions to OpenStreetMap. I wanted to let you know about a best practice for drawing parking lot aisles to help you in future mapping. The paths should never cross over themselves or overlap on top of themselves. So parking lots like Honey Creek Mall shouldn't be drawn with a single path, but instead use many individual paths. Maybe break it up into a one path per horizontal line, and then vertical lines that connect each of the horizontal endpoints.

Shouldn't way/675236748 be a rectangle? Right now, it is just a three sided way that doubles back on itself.