b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 169647551 | 5 months ago | RE: way/892128195 As mentioned in my previous comments on a change you made, the lines that define fairways and greens must not cross over each other like you've done here at the green/hole named "Beginning" and "Double Green". Please make sure you clean those up and refrain from cross golf course areas like this in the future. Thanks. |
| 169587938 | 5 months ago | RE: way/1417972338 Hey there Matub, TL;DR You're missing a couple of shared nodes when you draw the boundary between the green/fairway in the above-mentioned link. Please make sure every node is shared. In this case, you missed node/13030728744 and triggered a Q/A check. When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks. |
| 169618585 | 5 months ago | dang it! |
| 169622946 | 5 months ago | sorry |
| 169486199 | 5 months ago | RE: way/1417411338 Hey there dscott, I've noticed this error several times in the past couple of days and wanted to bring it to your attention. You are doing a great job of sharing nodes between the fairways and the greens, but you will sometimes miss a single node (node/13025446812 in this case) and that will cause Q/A tools to flag that as an overlap and needing attention. Can you be extra careful and make sure all nodes are being shared and none are left out? Thanks! (If you ever want to learn a more advanced tool like JOSM, you'll find that it has tools that make drawing of shared lines a breeze and will save you a lot of time. Reach out if you ever want to know more about that.) |
| 169524343 | 5 months ago | RE: way/1417600792 When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens, bunkers, tees, or other golf course areas for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
| 169526211 | 5 months ago | oops |
| 124996799 | 5 months ago | Thanks for the quick response. My first clue that something was amiss was that the unit number wasn't the hole number. If it was, I wouldn't have asked about this oddity. Out of curiosity, I'm assuming that these "addresses" are posted clearly on the course? I hope they stick mailboxes all over the course and affix reflective stickers to them. LOL |
| 124996799 | 5 months ago | Are nodes like this one on a golf course valid?? node/9958323090 |
| 169421198 | 5 months ago | RE: way/1416520860 When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
| 169411507 | 5 months ago | RE: way/1417009167 When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks. |
| 169365241 | 5 months ago | Thanks. I appreciate the effort. However, if you are unable to make sure every node snaps, it might be better if you just leave it as is and wait for me to get around to cleaning it up (since I will have to clean up yours as well.) You might as well save yourself the effort if it will just be changed shortly. I have fixed about 20,000 of those fairways so far this year and have about 10,000 more to go. |
| 169350987 | 5 months ago | RE: way/1034601463 Please don't share the nodes of the green if you have the fairway surrounding the green. If you can't see any fringe around the green, you should make the fairway butt up to the green and share the nodes on the boundary *between* the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks! |
| 169365241 | 5 months ago | RE: way/1098845345 Hey there Camel, thanks for helping out with my golf course mapping challenge. I appreciate you lending a hand. I wanted to let you know though, when you are drawing the nodes between the fairway and the green, you need to make sure every node is shared on the boundary. iD should "snap" the line when you get near the other existing node. If you don't do this, it will trigger a Q/A check for "overlapping" features. If this doesn't make sense, let me know and I'll try to clarify. Thanks! |
| 169302106 | 5 months ago | RE: way/1416564391 When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. (The same can be said about fairways and bunkers, tees, roughs, etc.) There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
| 169261967 | 5 months ago | RE: way/677780399 When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
| 169248708 | 5 months ago | RE: way/835073894 FYI, you added the fairway tag to the way mentioned above, but that was unnecessary (and wrong) since the combination of the fairway and green were already correctly tagged in the multipolygon relation. Please be careful when tagging ways that belong to a relation. It's often the case that the relation defines the object, instead of the components. Thanks. |
| 169118861 | 5 months ago | I wouldn't say you're "responsible" necessarily, but it sure would be appreciated if you did introduce quality errors like overlaps into the map. |
| 169175639 | 5 months ago | RE: way/1416012868 Hey there Max, There were a few problems with this change that I will fix but wanted you to be aware of in hopes you avoid them in the future. * Around the hole listed above, the tee box to the West of that rough had a golf=hole way that had two nodes in the tee box. The typical way to map a hole line is to just map from the farthest tee.
As I mentioned, I've corrected all these, but just wanted you to be aware. Thanks. |
| 169118861 | 5 months ago | RE: way/1271590618 When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the lines used to outline those areas are not allowed to cross over each other. Fairway outlines shouldn't cross over greens or bunkers for example. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |