b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 165839307 | 8 months ago | RE: way/1383740199 Hello DBliss, Please don't map a fairway as to adjoining objects. There doesn't seem to be any clear reason why that shouldn't be a single object that surrounds the green. You should be able to select both of them and "Merge" it and your editor will do the right thing. Please reach out if you need help. Thanks. |
| 165867264 | 8 months ago | RE: way/791902954 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 165866837 | 8 months ago | Hello Chris, What's up with the shape of the fairway on Hole 2 near the green? I'm not sure what you're trying to do, but it looks like no other golf course hole and I'm concerned there is a mistake in there somewhere. But I'm not sure your intent, so I wanted to check first. |
| 161066547 | 8 months ago | Hello Badrinadh, Why are you mapping both sides of walls in way/1349033276 (for example). Wouldn't it be much cleaner to just map the wall as a single line. |
| 164733672 | 8 months ago | I think there is something very wrong with way/1223105432 but I'm not sure how to fix it. Sounds like you might be more local and can make the appropriate fix. Thanks. |
| 163532681 | 8 months ago | Why are you adding the neighborhood border when it already exists (way/646100522)? Please remove it so there are duplicates. Thanks. |
| 163673760 | 8 months ago | I've reverted this change as it messed up a bunch of lines around the church property. My guess is that multiple things were selected while you moved a point thinking that you were only moving a single object. Feel free to attempt fixing up the parking lot, but make sure you review your change fully before uploading. Thanks. |
| 131145551 | 8 months ago | I never know exactly how to mark a business as no longer what it is, but I am aware that disused as a "lifecycle" tag is used. I would have to read up on if it should be "disused=golf_course" or "disused:leisure=golf_course" and remove the "leisure=golf_course" tag. But you'd have to double check the docs to be sure. |
| 165743519 | 8 months ago | Thanks bp. We appreciate the help. |
| 165743519 | 8 months ago | RE: way/856864124 Please don't share the nodes of the green if you have the fairway surrounding the green. If you can't see any fringe around the green*, you should make the fairway butt up to the green and share the nodes on the boundary *between* the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. * The bad imagery that I looked at did show a very faint difference between the green, fringe, and beyond. I would assume your Lucas County imagery was probably better and made that even more obvious. But either way, you should put the fairway all the way around the green if there is no space left for the fringe. Thanks! |
| 131145551 | 8 months ago | Thanks. Didn’t mean to sound like I didn’t believe you. Just wanted it better documented. |
| 165734044 | 8 months ago | RE: way/1383047196 (and at least one other fairway): I noticed that you are skipping some nodes when you are sharing the border between fairways and greens. This causes the fairway to overlap the green which is incorrect. Please make sure you share every node at the border. thanks. |
| 165698661 | 8 months ago | RE: the fairway/green on hole 10 (and possibly others)... As I pointed out in a previous comment on one of your changesets (changeset/162408944), you shouldn't be intersecting the ways that define the borders of greens and fairways (and most other golf course elements as well). Please read up on the wiki mentioned in those comments and start mapping golf course elements properly. Thanks. |
| 131145551 | 8 months ago | Can you back up your claim that the golf course is "disused"? |
| 165698353 | 8 months ago | RE: way/902258145 Hello Vurmilion. The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
| 165696831 | 8 months ago | Not sure why the designers of iD decided to display it in that way. I don't use iD much. I prefer JOSM for all of my editing. You can even customize all visual aspects of it. I could make greens be a dashed red line and fairways be a 2 pixel wide yellow line if I wanted. |
| 165696831 | 8 months ago | Hello there tdaco. Thanks for your contributions. Please make sure your fairways don't intersect with other golf elements (like other fairways, greens, sandtraps, water hazards, tees, etc.). Hole 1 and 2 fairways for example are overlapping. If you have to put them together, you should share the nodes of all border nodes by hovering near another node and iD will "snap" to the hovered node and share it.
|
| 165564624 | 8 months ago | That's fair. I guess I'd do a couple of things to improve the situation. As the curve between the two is completely arbitrary, I'd make it a straight line to make it more obvious that it is a conceptual separation of the two. That's completely optional. The second thing I'd do, and is more important is to add ref= tags to the different fairways. Tools that see adjoining fairways and roughs would see them as the same and try to combine them. Since there is a valid reason to leave them separate, tags would help make that clear. |
| 165564624 | 8 months ago | I don't think there is a good reason for you to split the fairway into two separate objects like you did here. Can you help me understand why this shouldn't be a single fairway polygon? Thx. |
| 163757476 | 8 months ago | You might want to read up on multipolygons and look at other examples of large multipolygons that are made up of several segments that define outer boundaries. (You should also consider using better tools to map multipolygon relations than iD. JOSM would be a good choice.) |