OpenStreetMap logo OpenStreetMap

Changeset When Comment
165483071 8 months ago

Hello Mlap,

Please make sure you share all of the nodes between a fairway and green and don't leave some of them unconnected. Doing that will leave odd gaps or possible even worse, overlaps. Thx.

165476200 8 months ago

RE: way/1381464169

Hello J,

You continue to map fairways and share the nodes on the outer edge of the green instead of excluding the green and sharing nodes on the border between the two. Please see my previous discussion and wiki links at changeset/165348686.
If you have any questions, please reach out.

165483517 8 months ago

RE: relation/19036918

Hello Green. Thanks for cleaning up the boundary between the fairway and green. That looks much better. You should know though that when you removed the fairway from the multipolygon, you left a dangling relation with a single member, which isn't quite right. Mapping around the tee was fine, but you need to make sure you leave the relations correct (or properly removed). You should also share the nodes at the boundary between the tee and fairway instead of a random sized gap between the two. Thanks.

165434763 8 months ago

RE: way/1378459716

You comment is that you fixed bad overlaps, but I still see some overlaps. If you don't share every node between the fairway and green, you'll get some zigzag and there will be some overlaps and some gaps. Every node must be shared. Let me know if that doesn't make sense. Thx

165399081 8 months ago

RE: way/1380987319

Hello Vurmilion. The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

165348686 8 months ago

RE: way/1380360712

When mapping fairways and greens, please don't reuse nodes between the green and the fairway when the green is inside the bounds of the fairway. If there is a visible "fringe" around the green, you should represent that fringe by leaving a gap between fairway and green. The two features should also be merged into a multipolygon by selecting both and selecting Merge after right clicking on them.

See the following for more information on mapping golf course features: leisure=golf_course#Common_mapping_pitfalls

thanks.

165354769 8 months ago

RE: way/1380451131

As mentioned in previous changeset comments, there are problems with how you map golf courses that need to be fixed.

Your fairway is sloppily overlapping the green. See changeset/164257920 for some wiki links to help you understand how to properly connect fairways and greens.

You are also destroying multipolygon relations by deleting the existing fairway and recreating it, leaving the relation definition broken. See comments here: changeset/162903940

If you need help understanding these things, please reach out so we can get you on your way mapping courses correctly. Thanks.

163869963 8 months ago

It's entirely possible that what I did the second time around was slightly different. That would explain why rendering works for you now. I think this has something to do with a way that is shared between two relations, but I only completely loaded one of the relations, but not the other. That's my best guess at this point. I'll pay more attention to that in the future. thanks for pointing it out.

165307838 8 months ago

RE: way/1380126635

Hello Kelvin,
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

165307330 8 months ago

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

165262828 8 months ago

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

164704675 8 months ago

Can you please fix up way/1120471967 and way/1120471966 ? I'm not sure how they are supposed to be oriented from the change.

164704675 8 months ago

fsdf?

165176444 8 months ago

RE: way/1379008922

Please do not make a multipolygon relation with 20 different line segments that define the boundary of a fairway. The fairway should be a single closed path. Not one made of many different pieces.

Also, the fairway should extend around the green and share nodes with the outside edge. You should either leave space for the fringe, or you should draw the fairway on the inside boundary of the green, making sure to share the nodes on the boundary. Thanks.

165175953 8 months ago

Hello Enjoister,

You are breaking/deleting multipolygon relations and leaving behind a comment of "Fixing" fairways. This is actually not fixing them. You might be confused, but just in case I'm the one that is confused, can you explain what is wrong with the fairways before you deleted the relation? I'm confident that they are correct and want to chat with you discuss any issues. Thanks.

165138089 8 months ago

If you're interested, there is a MapRoulette challenge for cleaning up partial overlaps between fairways and greens.

https://maproulette.org/browse/challenges/50926

165128562 8 months ago

Hi Ronca, thanks for getting back to me. I'm glad to hear that you are fixing things, but it is unclear that you understood my message and are now familiar with relations and multipolygons and how to edit them. Can you please address those concerns? Thanks.

165092151 8 months ago

Oh, and if you're asking why that particular segment doesn't have any tags, that is because it is part of a larger relation (relation/8143217) that carries all the tags for the members of the relation. Is that what you were asking?

165092151 8 months ago

Hello Charles,

There is a limit to the number of nodes a segment can contain. The limit is 2000 nodes. If someone new comes along and wants to refine the way and add a few nodes, it is confusing on how they proceed and split the node up and make sure the relation exists and is ordered correctly.

There are QA tools that flag any segments that are over 1800 nodes. I work to make sure those segments are under that trigger limit so that newer users don't have to worry about bumping up against the 2000 node limit.

Does that help?

165132286 8 months ago

RE: way/1378753422, et al

Hello Meatsia,

The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!