b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 162881106 | 10 months ago | Hi there Course, I noticed that you tried to make the fairway and green get very close to each other without actually touching. It is very important that they don't overlap, but it is equally important that there is no gap between them (except for those golf courses where the greens are specifically manicured to be separated from the fairway). But in the case of this particular hole, the fairway and greens should be sharing the same nodes at their boundary, not inches away from each other. For more information, see the wiki page for golf courses at leisure=golf_course#Common_mapping_pitfalls Thanks. |
| 162912426 | 10 months ago | Thanks for responding to the feedback. Overlapping is bad, but so is "almost touching". What you should be doing is sharing the nodes between the green and the fairway. Take a look at the wiki (leisure=golf_course#Common_mapping_pitfalls) for examples. I've gone ahead and fixed way/1361164081 if you want to look at that for an example. Can you show me where you were advised to do the overlapping? We're trying to catch bad instructions going out at the source so we can get things done correctly from the start. When someone says to do something because it "shows better", that is called "mapping for the renderer" and not necessarily mapping correctly. We want to make sure the map is correct, not just that it "looks good". Thanks. |
| 162836424 | 10 months ago | Very cool. We always appreciate good golf course mapping. Be sure and read the wiki to find other great tips on mapping courses: leisure=golf_course |
| 162836424 | 10 months ago | Thanks for the contributions Ratelimiter. FYI, greens that don't have specific names (very rare) shouldn't have "#2 Green" added to them. The name should be left unset. You can put "ref=2" on the feature, but if there is already the straight line golf "hole" with proper "ref" tagging, putting one on the green is redundant. Thanks. |
| 162836496 | 10 months ago | Hey there mbuenger, Please see the OSM wiki on mapping golf courses. You shouldn't have fairways and green intersecting or partially overlapping each other. leisure=golf_course#Common_mapping_pitfalls Thanks. |
| 162655651 | 10 months ago | Hi Yuliya, Why remove the service=parking_aisle tag on what is clearly a route through rows of parking spots? |
| 162787877 | 10 months ago | Thanks for helping clean up some bad golf mapping! |
| 162833292 | 10 months ago | Hi Bobby, Thanks for helping the OSM community improve golf course mapping. There's a small problem with how you mapped the first hole (and possibly others) that I wanted to let you know about so that you change how you do it in the future. The way that it was before is super-wrong, so I'm glad you're working on improving it. The fairway had been marked in such a way that it intersected the green and partially overlapped it. What you did was made the fairway go all the way around the green and you reused the nodes of the green. The problem with what you did is that it isn't topologically correct. There are two ways to handle the green. The first is that, if you can see it in satellite imagery, leave room between the fairway and green. This is called the "fringe" and isn't always obvious from imagery. And when the fairway fully surrounds the green, it should be turned into a multipolygon. The second way is to make the fairway butt up against the green by sharing nodes between them, but exclude the area of the green instead of surrounding it. This is a wiki page that describes how to do the above: leisure=golf_course Let me know if you have any questions. |
| 162680020 | 10 months ago | On rereading your sentence, if you are selecting multiple greens and multiple fairways and grouping them once, that won’t work. You need to select one enclosing fairway, and anything that is fully contained within that fairway and group just those together. |
| 162680020 | 10 months ago | No worries. Thanks for responding! I’m always here to answer golf course mapping questions. The best place to start is the following wiki: leisure=golf_course Can you leave a comment here about which fairway you are getting that error on? You should be able to get a link to that specific option on the bottom of the left sidebar. Or could be that the fairway and green intersect each other. That is the most common problem and needs to be addressed first before grouping them. |
| 162718451 | 10 months ago | Instead of adding "surface=grass", you should *replace* "landuse=grass" with "surface=grass". |
| 162710716 | 10 months ago | Fairways and greens shouldn't intersect. To properly map them, please see examples on the golf course wiki, paying close attention to the "common pitfalls" section towards the end. Thanks. |
| 162719448 | 10 months ago | FYI, things like cart paths (and most other golf course features) don't have names. To add a "name=Cart Path" tag is incorrect. Just tag it with "golf=cartpath" along with "highway=path" instead. |
| 162680020 | 10 months ago | Hey there Jpipe323, Thanks for your contributions to golf courses on OSM. We appreciate the efforts. I was wondering if I could ask a small favor in case you continue to map golf courses. When you draw a fairway like way/1361016157, could you select both the fairway and the green and combine them into a single object (called a multipolygon) by pressing "C" on the keyboard or right clicking and selecting "Merge". That would save me the effort of coming back at a later date and making that change myself. Thanks! |
| 162680914 | 10 months ago | Hi there AsYouAre, Just wanted to let you know that a change you made to way/918883786 was incorrect. You tagged the outer ring that defines the fairway as "golf=fairway", but it was already part of a multipolygon that correctly defined that. To add that tag when it already existed is saying that everything inside that polygon is fairway, including the green, which isn't correct. I'll fix it. I just wanted to let you know so you could avoid that in the future. |
| 162613403 | 10 months ago | Thanks djjherp for contributing golf courses to the map. In the future, when drawing a fairway that surrounds a green (i.e. way/1360644967), could you combine the fairway and green together (select both and press 'C' on the keyboard) to create a multipolygon? Thanks! |
| 162621635 | 10 months ago | Hey there Brad, Thanks for your work on golf courses. I'm hoping you can do a favor for me that will save me some future work. When you draw a fairway that surrounds a green (and other things like bunkers), could you select those items and combine/merge them together into a multipolygon? The keyboard shortcut is 'C' in iD. Thanks! |
| 162542008 | 10 months ago | Thanks for listening to my suggestions Steve. It's great to see you creating the multipolygons around the green now. I really appreciate it. I noticed that you are making golf=fairway polygons around the green that butt up against the rest of the golf=fairway polygon for the hole. They are typically considered to all be the same fairway and should be represented as a single polygon. That's how it's typically mapped from my experience. |
| 162474865 | 10 months ago | Thanks Steve. There's nothing inherently wrong with fairway going around the green. You just have to make sure the lines don't intersect/touch and that you combine them into a multipolygon. For instance, if you look at way/1352433807, you can see it has great imagery and the fairway grass can be seen going all the way around the green. In that case, draw the fairway all the way around, select both (shift click them) and then type 'C' to "Merge" them together into a multipolygon. |
| 162408944 | 10 months ago | There's a problem with some of your golf course mapping. You've made fairways (for example way/1359162412) that intersect other features on the course. In that example, the green. These intersection shouldn't happen. See leisure=golf_course#Common_mapping_pitfalls for examples on how to properly map golf courses. Thanks. |