OpenStreetMap logo OpenStreetMap

Changeset When Comment
159898727 12 months ago

Hey there Numac,
Thanks for the golf course contributions to OSM. I notice that you're putting in what I call "lollipops" when you are drawing the fairway around something like a sandtrap. The proper way is to just draw the complete fairway and the complete sandtrap as is, then select them both and "combine" them (in iD) into a "multipolygon". If you need help, please reach out and I'll help you along. Thanks!

160664213 12 months ago

High desert golf must be something wild.

160327226 12 months ago

Thanks CurlingMan. It's my goal to get all of lollipops in golf courses cleaned up this year. You can read more on the OSM-US Slack server in the #golf channel if you're interested.

160515620 12 months ago

The translation of your comment to English makes zero sense, so you’re going to have to translate this for me or I can’t help you.

160401311 about 1 year ago

Hey there mech32. Nice to see that other people are actively working on golf course mapping. Thanks for your contributions!
There is one thing that I'd love to see you (and others) change in how things are mapped regarding fairways and greens. I see a lot of fairways that extend onto the green such that the ways for the green and fairway overlap, which isn't topographically correct. It might look okay when rendered, but isn't the "right way" to map things. It's like your saying that grass in the overlapping part is both green and fairway, which isn't right.
The correct thing to do would be to draw the fairway all the way around the green (extending slightly) and then combine the green and fairway into a "multipolygon" that says this whole thing is a fairway EXCEPT for the "inner" polygon that is the green. Here's an example: way/1232699314.
Alternatively, if it makes sense based on satellite imagery, run the fairway up to the green and re-use the points of the green to define the border between the green and fairway.

If any of that is unclear, please let me know and I'll work to better explain it. Thanks!

153784489 over 1 year ago

Ugh, yes, this is a known issue with "https_all_the_things". See https://gitlab.com/b-jazz/https_all_the_things/-/issues/8.

It happens very rarely though so it hasn't been a high priority (as you can see) over the last 5 years. I can't make any promises, but I'll see if I can dedicate some more time to getting a fix implemented. Feel free to follow the issue on gitlab to get updates.

In the meantime, I'll fix the mistaken edit. Thanks for pointing it out. Much appreciated.

147116638 almost 2 years ago

Thanks for the contributions loralyn. There are a couple of problems that exist with adding the fact that the school is part of the town. First, you shouldn't just draw an arbitrary way (line) and tag it as being a town. The town boundary already exists and it should be modified. Another problem is the truth of that school belonging to the town of Ebensburg or Cambria. I don't have enough knowledge as I'm not a local so I don't want to make the corrections myself without knowing the history. But it seems like your way (1246747603) should be deleted at the least, and then some clarification should be made as to where the school actually belongs.

146163424 almost 2 years ago

I definitely blame the tools, but I think it is far more than just iD. I wonder if there is some shared component that introduces the bug across several editors. I should do some analysis.

145554986 almost 2 years ago

No worries. It happens all the time. Probably some subtle bug in the editor you're using.

129126623 about 2 years ago

FYI, something broke with your toolchain and the output made it into the website tag.

143626848 about 2 years ago

Phone numbers in my area don’t have an area code or country code, but the correct format is to include both of those. Same idea for website URLs.

144202706 about 2 years ago

Thanks for your note. Could you please expand what you mean by this comment? It’s not clear to me which edit you have a problem with and what that problem is exactly. Thanks.

143878554 about 2 years ago

I’m not sure what the purpose of this comment was. Is there a request for an action to be taken?

143702413 about 2 years ago

The bot isn’t arbitrarily adding a trailing /

143339729 about 2 years ago

What?

143095406 about 2 years ago

Hey vgeorge, thanks for the report.

The bot doesn't prepend "www" to any URL. It also doesn't add a trailing "/" to them either. If you look at a request to the previous URL, you can see what the website is redirecting people to:

$ curl -I http://virviramos.com.br
HTTP/1.1 302 Found
Date: Thu, 26 Oct 2023 15:20:32 GMT
Content-Type: text/html; charset=iso-8859-1
Connection: keep-alive
Location: https://www.virviramos.com.br//

I'm hesitant to make any assumptions and replace the erroneous "//" with a single "/" or even remove it altogether. What are your thoughts?

I did a query on this in my area and found dozens of websites that redirect to https://www.example.com//, so it is far from uncommon.

142807797 about 2 years ago

“You can please some of the people all of the time, you can please all of the people some of the time, but you can’t please all of the people all of the time”.

― John Lydgate

I've tried it both ways (few changesets with many changes, and many changesets with few changes) and someone always complains about it. Sorry, I'm going to stick with it as it is. I wish it wasn't something people complained about.

141943305 about 2 years ago

Can you look at node/685284562 ? It got messed up during your change and I'm not sure what the cleanest way to fix it is. Maybe you could help?

67448659 about 2 years ago

node/5899284188 has a broken website link. I'm not sure what it should be. Someone should either fix it or delete it.

141225581 about 2 years ago

Can you take a look at way/384638461? It seems to zig-zag and cross all over itself, and that goes against basic mapping rules. If you could clean that up, it would be appreciated. Thanks.