OpenStreetMap logo OpenStreetMap

Changeset When Comment
87370508 over 5 years ago

For example see https://osmcha.org/changesets/87368583 which put a building=* as the footprint and then the towers inside it with different heights as building:part=*

87370508 over 5 years ago

Though same applies to way/335699134 it would be the footprint so building=* and then the parts way/618221458 and way/618221457 would be building:part.

87370508 over 5 years ago

^ talking about way/16748116/history

87370508 over 5 years ago

hi could you say a bit more on why this should be building:part? According to osm.wiki/Simple_3D_buildings#Building_parts typically the building footprint would be building=* and then if you need to add parts which have different physical characteristics then you'd add extra building:part=* ways inside. In this case which building=* is this inside? The way itself already has building=* so I don't see the need for building:part.

87242841 over 5 years ago

+1 to the ground survey to verify. But please don't use Google Street View, otherwise your edits may need to be reverted, see https://help.openstreetmap.org/questions/710/can-i-use-google-streetview-to-help-create-maps on why we don't use Google Street View for mapping in OSM.

87242841 over 5 years ago

hey @speedmeup, we can't just assume that the TfNSW Speed Zones data is 100% accurate, so it should only really be used as a guide to address areas which OSM may be wrong, or to add in missing speed zones. So it would be wrong to just change everything over blindly to match their dataset.

87238591 over 5 years ago

Hi did you really mean to move https://osmlab.github.io/osm-deep-history/#/node/3571292104 so far or was that an accidental drag?

67948422 over 5 years ago

Was there a reason for removing ford=stepping_stones from https://osmlab.github.io/osm-deep-history/#/node/2491748968 ?

86950173 over 5 years ago

Hi, welcome to OSM. Just a tip generally the name tag is used for proper names, not to describe things osm.wiki/Good_practice#Don.27t_use_name_tag_to_describe_things.

So usually XXX Fire Trail, is there a signposted name? If not you can just omit the name tag.

Simply motor_vehicle=private is a much more common practice where only authorised vehicles like emergency services and maintenance workers can drive access=*#List_of_possible_values

access=permit is used commonly but not documented, so I can only guess it's more applicable where you can anyone can apply for a permit?

86799691 over 5 years ago

Hi welcome to OSM. Could you please provide your reasoning for this change? leisure=nature_reserve says "A nature reserve is a protected area of importance for wildlife" which this aquatic reserve seems to match. This can be tagged together with the protected_area tagging, which covers more detail than nature_reserve. What's area=yes needed for? The fact that this is a closed way indicates it's an area already.

86702413 over 5 years ago

Hi per railway=station#A_Simple_Railway_Station and public_transport=stop_position the stop_position can still have the station name, so I'll add that back in.

86703802 over 5 years ago

Yep I just noticed and fixed the building tag.

86703802 over 5 years ago

I've just now restored the retaining walls you added, so the pedestrian area change you made was reverted + the area to node was reverted, but retaining walls added was retained, was that everything?

86703802 over 5 years ago

I've reverted this change until it can be discussed. Personally I think the area is better as it covers the whole station area. It's more consistent with all the other metro stations and eventually we'll get around to converting all train station points into areas.
railway=station#A_Simple_Railway_Station indicates it's reasonable to map as an area.

86725100 over 5 years ago

Hi just a few tips, junction=roundabout implies oneway=yes so there is no need to add the oneway tag junction=roundabout.

Also you deleted the cycleway:left tag and added cycleway:right both =no. Is there ever a case where you have a cycleway on the right side (inside) of a roundabout? Do you need to say =no here? https://osmlab.github.io/osm-deep-history/#/way/171015278

86725282 over 5 years ago

Hi while it's not harmful to specify lanes:forward and lanes:backward, where the lanes tag is already set and is even and where oneway is not yes, then it's assumed forward and back are just half of the lanes tag.

86644098 over 5 years ago

Hi I've reverted this change because as you said yourself, it does exist on the ground, and generally if it exists on the ground it's fair game to be mapped see also osm.wiki/Good_practice#Map_what.27s_on_the_ground. I have updated it to use the power=minor_line tag which is a better fit for these smaller lines power=minor_line

86614299 over 5 years ago

hi for future reference if you want to to make a note without editing, just add a note and please don't use the viewpoint tag as a note.

86589422 over 5 years ago

Hi looks good, but I noticed a couple you did as multipolygon relations but they only have a single outer member. Any particular reason these weren't just done as a regular way?

86411376 over 5 years ago

According to amenity=ferry%20terminal it should be public_transport=stop_position not station. I think this point was meant to only represent the stop_position in the public transport relation osm.wiki/Public_transport#Service_routes. Have you considered all the wiki documentation for this change? I haven't taken the time yet to fully dig into it, but are you sure this change is correct?