Hi, welcome to OSM editing :)

Unfortunately it seems like you contributed personal details (a stay duration in various hotels) rather than general information about those places (like their website, opening hours, etc).

Remember that OSM is one big public database used by everyone. If you want to plan a trip using maps.me, I suggest droping/naming pins instead of using the edit feature.

Because of this, I've [reverted your changes](changeset/38843451). Don't hesitate to tell me if I've misinterpreted things somehow.

I encourage you to try editing again during your travels. Add a missing restaurant, update a changed name, etc. Just as long as it's public information :)

Ok :) This is a great location to get started with osm editing. Lots of details can be added, especially if you can survey. Have fun. Don't hesitate to ask me or the commmunity if you have questions.

I suppose that should be amenity=social_facility ?

Also look at http://taginfo.openstreetmap.org/keys/social_facility:for#values to get a feel of possible values. By osm convention, parsable values shouldn't contain spaces. My guess is that 'disabled' would fit best (balancing genericity for data use against more positive terms for human interaction) but it's up to you.

Lastly, it seems like all these buildings are part of the same site ? It might be better to map a social_facility polygon that encompasses them all, and tag individual buildings with the non-shared properties only.

Hi Conal, welcome to OSM :)

Your contributions look ok so far, but just a few tips before you continue:

Your addresses are a bit mixed up:

* "addr:city" is for the actual town, like "Roscrea". Only add it if the house belongs to that town, not if is fully in the countryside.

* "Ofaly" would go in the addr:county key, except that it is completely unnecessary because we can fetch that information from the county's shape.

* addr:housenumber should be a number :p and addr:housename is something like "River view". Many houses in Irland lack one or both, so it's ok to not tag it.

If you can, map the building outline rather than just a node. You can use the satellite imagery for that.

Lastly, grouping your changes a bit might help reviewing them. For example, add all the houses along the road in one go.

Happy mapping :)

Please use changeset comments to explain the changes you made, not as an advertising platform.

The actual changes seem fine in this case, but somebody reading just the comment is likely to flag the changeset as spam and revert it.

While at it, it the restaurant you added accessible to anybody ? If it is only accessible to hotel guests, it's probably not a great idea to map it like this.

No problem, we all make mistakes along the way.

Concerning the hotel (and POIs in general), it's pretty much always better to map them as areas if possible. Reducing an area to a node loses information, so don't do that. If the mapped hotel area was indeed too big, you should have changed it geometry to reflect that.

But are you sure that the buildings at the back aren't part of the hotel ? Did you survey that fact ? It is pretty common in the west of ireland for hotels to have dependencies like this. And the original mapper of that feature did so after a survey (see how changeset comments are useful ? :)). I'll invite him over to this discussion.

Partial revert done in changeset/37142532 , keeping the good parts and restoring deleted stuff.

Please do not delete valid details from the map, other mappers have already complained to you about this in changeset/37062732 . There are for example quite a few issues with this changeset:

* You replaced the perfectly correct hotel area with a less-informative node.
* You removed lots of existing service roads.
* You changed the type of road from service to unclassified, which is wrong for these roads.
* You didn't include a changeset comment.

Adding the restaurant and parking, and improving the way geometry are good things. But you need to respect other contributors's work (don't delete stuff you think is not relevant enough, provide comments iin your changesets to make your intent more understandable) and to check on your tagging knowledge (the difference between service and unclassified, the mapping of a hotel area).

Cheers.

Nice, a townland mapped 5 years ago :) I hope you'll like the new version: relation/5913060

If you feel like getting back into mapping, now is as good a time as any. We're making great progress on townlands and, after years of work, expect to be done this summer : http://www.townlands.ie/

Cheers.

No worries, it happens. Don't hesitate to contact the contributor next time :)

Sorry for the tone of my first comment to your changeset: I was just after arguing against that proposal on the tagging mailing list and got annoyed when I saw my recent work undone.

As I have already argued on the mailing list and this changeset discussion, using name_1 and name_2 here is IMHO better than the alternatives.

See https://lists.openstreetmap.org/pipermail/tagging/2016-January/028057.html and https://lists.openstreetmap.org/pipermail/tagging/2016-January/028125.html

Cheers.

Firstly, there are 3 names alltogether, I can't put two in loc_name (no, I don't want to use a semicolon).

Secondly, there's really nothing telling me that loc_name would be more appropriate than alt_name or old_name or name. They're just all names I know this place has, and I don't think classifying them using a *_name would make much sense.

Reverted.

No no no, what made you think these were typos ? I hope you're not making similar fixes elsewhere ?

They are alternate names, 3 variations in total, one official from GSGS and two from local knowledge.

I copy-pasted that text from note/480013 but thought I was more likely to reach you here. Please don't hesitate to ask if you have questions.

We could do with more contributors in County Cork, so I hope you'll start contributing again, removing those name tags being a first easy step :)

If something is a "natural=tree", there's no need to give it the name "Tree" as well. If something has no name, there's no need to create one just for OpenStreetMap. See osm.wiki/Names#Name_is_the_name_only for more details.

@Vincent de Phily/diary/37468

Hi, welcome to OSM :)

Adding this POI is a good start, but if you want it to show up on map renderings, searches, etc, you'll need to say what it *is* in addition to what it is *called*. I don't know the place, but you probably want to add "shop=door" or "shop=hardware" (osm.wiki/Shop). Other typical useful tags for shops are website and opening hours (osm.wiki/Opening_hours).

Another tweak: it's probably better to add the business park name to the business park object than as an addr:street tag to POIs. Firstly it is more generally-usefull (all POIs within the park now have this bit of addressing), and secondly there's no actual *street* call that, only the area is.

Cheers, and keep mapping :)

Smaller changeset area please :)

Also watch out: near Westport you removed a waterway's layer=-1 tag without adding the corresponding layer=1 on the bridge. Fixed.

Welcome to OSM :)

If a shop is no longer open, it's better to replace the "shop=*" tag with the corresponding "disused:shop=*" tag, otherwise it's still interpreted as a shop by renderer and other consumers. It's not the only way to express this, but I won't confuse you with options :p See osm.wiki/Lifecycle_prefix , You can drop the opening_hours and operator tag too.

I had a look at your other edits; all good :)