OpenStreetMap logo OpenStreetMap

Changeset When Comment
144220624 about 2 years ago

also added new roundabout based on latest imagery

144059613 about 2 years ago

sorry didnt mean to add the last part, my bad, what I meant to put it:

next time you commit try to keep you commits in various areas local (restrained to one geographic area like a city or town) as to keep the geographic area down, this makes it easier to review.

144059613 about 2 years ago

2 points here, first, please next time try to keep you commits in various areas local (restrained to one geographic area like a city or town) as to keep the geographic area down, this makes it easier to review. Also please next time provide a change set comment describing what was done in the commit, for more information see osm.wiki/Good_changeset_comments for more details.

143823733 about 2 years ago

so, just to make sure we understand each other here; the edits on this commit (143823733) were good and should have been kept (I have since fixed the fact that this was reverted in a commit of my own), I had no issue with that. the only issue was with the fact that the change set comment (comment)=* inaccurately described what was done in the commit, thats it.

144085570 about 2 years ago

2 points here, first, please next time try to keep you commits in various areas local (restrained to one geographic area like a city or town) as to keep the geographic area down, this makes it easier to review. Also please next time provide a change set comment describing what was done in the commit, for more information see osm.wiki/Good_changeset_comments for more details.

143823733 about 2 years ago

I was not pointing out "improper modifications", just that the comment=* could have been better.

143823733 about 2 years ago

I dont know if I was misunderstood, it is preferable for the traffic_signals to be at the lines on the roads were the cars should stop, what this commit actually did was correct, my original message on this commit was to do with the change set comment on this.
I felt that "Added Stop Sign." does not properly describe what was done in the commit and was simply pointing out that something like "Updated Traffic Signals" would have better described what was done.
in short, my issue with the commit was not with the contents but to do with osm.wiki/Good_changeset_comments.

144117677 about 2 years ago

sorry, bad change set comment, updated alignment of sidewalks based on newer imagery

143992462 about 2 years ago

please respond, it would be nice to get those clarifications.

143992462 about 2 years ago

I have a few notes here, first, next time please try and keep the geographic area down, this could have been done as 6 ish separate smaller commits and it would have made it easier to review/understand.
second of all, what is your source for the deletion of way/1178243253, I ask because it is there on the latest imagery (National Agriculture Imagery Program, and Miami-Dade County Orthoimagery (Latest)).
Next, for way way/1081964592 why did you remove the bicycle=yes, does that mean that bicycle's aren't allowed because then it should be tagged as bicycle=no, otherwise why remove the tag?
last of all on several ways (such as way/1036045604) you put bicycle=Not Specified, I could not find any previous uses of this value (see https://taginfo.openstreetmap.org/keys/bicycle#values), what does it mean, shouldn't a more standard tag be used(like possibly permissive), the point I'm trying to make here is that, from my understanding of the tagging in this commit, "yes" seems to get across the same information as "Not Specified" unless there are signs specifying that bicycles aren't allowed on those sidewalks, and if it is that way bicycle=no would be more appropriate from how I see it. Just because there isnt a sign explicitly allowing bicyclists doesn't imply that they aren't allowed on that sidewalk at all, honestly from how I see it it would be the other way, unless otherwise specified you can bike on sidewalks. and generally the use of non standard tagging in cases were there really isnt a good reason to do so is usually not a vary good idea, tagging changes need to be approved through a community vote on the wiki.
otherwise, happy mapping.

143823733 about 2 years ago

wouldn't "updated traffic signals" be a better commit message since it better describes what was done in the commit since it wasn't stop signs that were added rather traffic signals.

143819850 about 2 years ago

when adding stop signs a better commit message would be "added stop sign" since you didn't change the alignment and because it better describes what was actually done in the commit.

143726042 about 2 years ago

wouldn't "added stop sign" be a better (better describes what was done in the commit) change set comment for this since that was what was done, since the actual alignment has not changed.

143557127 about 2 years ago

why did you add this when there is already turn:lanes=* tagging on way way/968569007 which represents the exact same information. If the turn:lanes=* tagging is wrong I feel it would have been better if that had been fixed instead of adding wholly new geometry. what I'm trying to say is that I dont think this is necessary and am wondering why you did added the link.
---

Published using OSMCha: https://osmcha.org/changesets/143557127

143366930 about 2 years ago

just a quick question, what is the source for this commit?

143187467 about 2 years ago

yes, it would be amazing if you would start adding changeset comments to your commits.

143090796 about 2 years ago

yes, please follow the changeset comment guidelines and keep the geographic area smaller, it can be really hard to tell what areas really large changesets like this effect so that they can be verified.

142847824 about 2 years ago

please stop removing the tagging of pedestrian areas, the "highway=pedestrian" specifies that this is a pedestrian area. see highway=pedestrian for more information, this tagging schema is approved so there is no reason to remove the tagging.

142944198 about 2 years ago

I'm sorry if this is me not understanding local slang/colloquialisms but what do you mean by "decoy road"?

also it would be wonderful if you used more words in describing your commits since it can be hard to tell what "around hwy 17 and decoy road", something like "did some edits around hwy 17 and added decoy road" would be better since it it easier to understand since without those extra words we dont have enough words to truly understand what you mean.

142472216 about 2 years ago

has the YouTube channel (USA RAIL GUIDE) given us (OSM) the right to use the channel's videos as sources in commits?