OpenStreetMap logo OpenStreetMap

Changeset When Comment
172962761 2 months ago

Hi! I believe the big signs on the facade of the banks say "Santander", not "Banco Santander" (see osm.wiki/Good_practice#Map_what's_on_the_ground), and the fact that it's a bank is already reflected by the `amenity=bank` tag. What do you think justifies putting "Banco Santander" into the `name`?

Additionally, "Santander Group" isn't really the name of the place, is it?.. Why do you consider putting it in the `official_name` makes sense?

172877459 2 months ago

Additionally, "Santander Group" isn't really the name of the place, is it?.. Why do you consider putting it in the `official_name` makes sense?

172877459 2 months ago

Hi! I believe the big signs on the facade of the banks say "Santander", not "Banco Santander" (see osm.wiki/Good_practice#Map_what's_on_the_ground), and the fact that it's a bank is already reflected by the `amenity=bank` tag. What do you think justifies putting "Banco Santander" into the `name`?

170281807 4 months ago

Thanks for checking, really appreciate it. I'll update my validation scripts (https://dld.sh/osm/pt/) to not enforce shop=convenience then.

170281807 4 months ago

Out of curiosity, what's you basis for changing the two My Auchan stores from shop=convenience to shop=supermarket? I see you're using iD which is most definitely suggesting to use shop=convenience (based on https://nsi.guide/index.html?t=brands&k=shop&v=convenience&tt=auchan#myauchan-f3ab02), the brand's Wikidata entry (https://www.wikidata.org/wiki/Q115800307) says it's an instance of "convenience store chain", and OSM Wiki (shop=supermarket, shop=convenience) suggests that a supermarket "is large enough to use trolleys". Does any of that contradict what you see on the ground? (your changeset doesn't actually specify if it's based on a survey or local knowledge, so I'm not sure; please consider supplying the source information in the future)

170274635 4 months ago

Starbucks seems to be a duplicate, did you maybe mean to move node/12619018789 to the right place instead?

167815758 6 months ago

If you go to https://www.burgerking.pt/pt/store-locator you'll see the website making a request to https://www.burgerking.pt/api/whitelabel when loading the page, and that endpoint returns the data that contains the refs. In this particular case, there're actually two different refs in the response payload: `_id` and `id` fields (used in URLs, i.e. "https://www.burgerking.pt/pt/store-locator/store/<id>"), and `storeId` and `number` fields (which are the ones that I'm using here); I decided to use the latter as they're always numeric while the former ones come in two forms ("restaurant_XXX" and UUID); I obviously don't know which one is more stable, I guess time will tell.

And yes, since it's burgerking.pt it only applies to Portugal. For Morocco (which is what I assume you're interested in) going to e.g. https://morocco.burgerking.delivery/find-bk seems to make a request to https://api.solo.skylinedynamics.com/locations which returns refs that most probably can't be correlated with the ones from Portugal in any way; I'd love it if there was a global source though (from BK itself). Note that I don't actually know if that's the official website for Morocco :) Also note that sadly there might be legal restrictions on using the rest of the data (just the refs is probably fine?..)

167834328 6 months ago

Olá Rui! Was that a warning that you fixed about Decathlon? Where can I see it? Their website (https://www.decathlon.pt/store-view/loja-de-desporto-ovar-connect-0070284802848) says that it's and "Ovar Connect", there're photos on the internet (e.g. at https://www.airinformacao.pt/2021/12/04/decathlon-connect-ja-chegou-ao-vida-ovar/) that show "Decathlon Connect" spelled out, and there're videos (e.g. at https://www.instagram.com/p/DJttfLIPvzp/ or https://www.youtube.com/watch?v=trLIETN5D9c) that seem to imply that Connect is a separate type/concept of stores for them. How do you propose to tag this if you (and/or the validation tools you're using) are against putting it in the name?

167694584 6 months ago

https://www.aldi.pt/ website spells it as "ALDI", not "Aldi", hence that's what I chose when unifying the tagging. Do you want to discuss and/or change it (for all the stores, not just this one)?

166722853 7 months ago

Amended in changeset/166800479. Feel free to update the addresses again once e.g. confirmed on the ground.

166722853 7 months ago

Hi PriceyPanda, please refer to osm.wiki/Google for this specific case, and osm.wiki/How_We_Map in general. There's if course much more information on the wiki you might find useful. Looking forward to your future contributions ;)

166722853 7 months ago

Hi PriceyPanda, and welcome to OSM! A few notes on your changes here:
* phones should be in international format, see phone=*
* specific website URLs should be preferred over homepages, https should be preferred over http, see website=*
* "Quinta do Moniz" is not a street name
* would be interesting to know your source for the Pingo Doce postal code, the one used previously was taken from their website

Would you please revise according to the above? I can do it for you (basically revert to the previous values) if you want.

Happy mapping ;)

165693196 7 months ago

Olá Rui! Percebo bem que isto vem de um survey? O website para node/12444352488 diz que é Worten Mobile, qual é o correto? Temos de os informar sobre isso?

162252596 11 months ago

Wiki (artwork_type=bust) says that "If a bust represents a specific person, it is a memorial and should be mapped with historic=memorial + memorial=bust.".

155838280 12 months ago

Hi. You seem to be using outdated imagery from 2018, the roads have changed since then. Reverted in changeset/160476691

151183513 over 1 year ago

Hi! You've changed amenity=parking_space to amenity=parking near the hospital. There was already a parking there, one that contained all the parking space areas (way/160504219); having parking areas inside parking area isn't right. Wiki (amenity=parking) says this: "Individual parking rows should not be mapped as separate parking areas. To get that level of detail, individual parking spaces can be mapped separately with amenity=parking_space."

151028932 over 1 year ago

Reverted the locations in changeset/151474753. Thanks for the prompt reply ;)

As for the parkings, after a discussion in Telegram I'm currently tagging them with brand=Telpark + operator=Empark (see osm.wiki/User:Mikedld/Portugal/Estacionamento/Operadores/Empark). Could discuss more if there's uncertainty.

151028932 over 1 year ago

Positions of node/8308985789 and node/8308727705 are now also incorrect (or much less correct). Not sure if you care, let me know.

151028932 over 1 year ago

[At least] node/8105019897 got moved in this changeset. Previous location was its true (or much closer to true) location underground, new location is instead somewhere near the one of the entrances and doesn't reflect its true location. Do you not want me to move underground chargers in the future?

149139197 over 1 year ago

Hi Paulo! Please check the definition for highway=secondary at osm.wiki/Pt:Tag:highway%3Dsecondary. What you have here is most likely highway=residential (osm.wiki/Pt:Tag:highway%3Dresidential) or highway=service (osm.wiki/Pt:Tag:highway%3Dservice). Same might apply to another recently mapped way at way/221910668. I would appreciate you reviewing these cases and making corrections. Thanks!