OpenStreetMap logo OpenStreetMap

Changeset When Comment
68986296 over 6 years ago

Reverted with changeset/69132555. See also changesets 69008313 and 69075100.

69008313 over 6 years ago

Reverted with changeset/69132499, see discussion in changesets 68986296 and 69075100

69075100 over 6 years ago

Hi Gorbs -- I was still watching changeset/68986296 and did not realize that you were continuing to make new changes.

Please stop making changes to the subways for now. When you make additional changes to the same objects, it's much harder to cleanly revert previous changesets.

I have reverted this changeset (69075100) with changeset/69132368. I'll now go back and attempt to revert the previous ones.

I look forward to joining the larger discussion of this topic whenever it occurs. In the mean time, please don't use the NYC subway system for your tests.

Thanks, jmapb

66042255 over 6 years ago

Hi promiseofbirth, the Bobby Wager Walk still has a closed section awaiting repairs. I tagged the closed section with access=no and clearly indicated this in my description and fixme:

way/654051378/history

Why did you remove this closure?

68986296 over 6 years ago

Yes thanks mdejean for making that distinction clear. The routes that subway stations serve are not part of the station names -- at least not in NYC. It's a tagging-for-the-renderer hack to pretend that they are. That aside from the questions of unicode support and repurposing a textual name field for a visual logo.

I've held off on reverting this so Gorbs can discuss it on the tagging mailing list, but I will revert don't see something soon.

69043292 over 6 years ago

Hi Elizabeth -- Just to let you know, it's against the prevailing ethics of OSM to use the description tag to add advertising-like messages to businesses. Phases like "highly specialized", "top rated" and "best in class" are not appropriate here and will likely result in those descriptions being deleted.

Thanks, jmapb

68986296 over 6 years ago

Firefox 60.6.1esr, Chrome 73.0.3683.103. Both current versions. (IE, whatever, who cares.)

But honestly, the real problem here is not browser support, it's that you're conflating the route's nomenclature with its logo design. It's not the "❶ Train" -- it's the "1 Train", and its logo is similar to a red ❶. It's understandable to want a map that displays the route logos next to the subway stops -- I'd love that -- but it should happen at the map rendering level, not by renaming the route to an inaccurate name that looks kinda like its logo.

68986296 over 6 years ago

Mapnik seems to support these circled unicode chars pretty well --though the labels at zoom 14 do take up a lot of space at complex stops.

Browser support is lacking for the circled letters though: https://imgur.com/a/WU3WtaV (these are current Windows versions of Firefox, Chrome, and IE -- I know nobody uses IE anymore, but whatever.)

Personally I'd love to see the line numbers/letters circled and in the official MTA colors, maybe starting at zoom 15 -- obviously that's a much more complex project and might be more appropriate for the Transport Layer than the default map. But this unicode renaming seems like a hacky half-measure.

What NYC page are you using for discussion?

68986296 over 6 years ago

Hello Gorbs. Please don't rename our subway lines without discussing the change with local osm mappers FIRST. Probably the best place to discuss this sort of thing would be the Talk-us mailing list.

I'm inclined to revert this changeset.

Thanks, jmapb

68941982 over 6 years ago

Hi dapanda2 -- Are you sure about including the football field along McDonald (Sid Luckman Field) as part of this park? The NYC Parks Dept website does not include it in the park's footprint ( https://www.nycgovparks.org/parks/friends-field/map -- it shows a smaller football field that overlaps the baseball diamonds) and the fact that it says "ERASMUS" makes me think it's owned by Erasmus Hall.

68946051 over 6 years ago

Hello Ragnix280 -- unfortunately this changeset has many errors and I had to revert it with changeset/68956252 . Thanks, jmapb.

66429149 over 6 years ago

I have surveyed and can't find any justifcation for these 50 mph speed limits. In fact, I found some 30 mph speed limit signs. Please reply indicating your sources for this data or I will revert this changeset.

68525508 over 6 years ago

Reverted in changeset/68848857

65603756 over 6 years ago

Hi Tomer, what's the source of the name "Empire State Complex - 1"? Thanks. Jmapb

67215664 over 6 years ago

March has come and gone, and there's still no bar here: https://imgur.com/a/VOMRaQ5

I've changed this node from amenity=bar to construction:amenity=bar, because it appears that something *is* under construction in there.

Check out the wiki page on "lifecycle prefix": osm.wiki/Lifecycle_prefix
That's the recommended way to map features that are not currently available to map users but nonetheless of interest.

Cheers, J

68712887 over 6 years ago

Hi apnaqua, I've reverted this changeset with changeset/68727452. Reasons:
- The bike lane on Plaza Street is definitely two-way, not one-way, so removing the "oneway:bicycle=no" tags is incorrect. See pics taken today at https://imgur.com/a/KYa3dZ2
- Adding "oneway=no" to the cycleways south of Union Street is not necessary. If a routing engine is treating these as one-way, that's a problem with the routing engine, not with the tagging.
- node/5837304274 (Wellington's kitchen studio) was relocated from Atlantic Avenue to Vanderbilt Avenue. I'm guessing this was just an accidental drag, but if this shop really has moved, please locate it inside the appropriate building footprint and adjust the address tagging as appropriate.

If you can describe what sort of routing problems you were trying to address with this changeset, I might be able to help.

Thanks, J

68611059 over 6 years ago

(Oh, PS, after you make address changes it may take a while for Nominatim to update.)

68611059 over 6 years ago

This is an interesting problem!

I think it's caused by the fact that the value of the addr:street tag is "Fifth Avenue" while the official name of the street on the map is "5th Avenue". You'd think Nominatim would be smart enough to know that they're the same... until you consider that it would have to know alternate spelling rules in 50+ different languages, and know which ones are likely to apply in what regions. Solvable problems, for sure, but I don't think they're solved in Nominatim at this point.

So, if I'm right, it searches for a match to "Fifth Avenue" and doesn't find it, so it just takes the closest street -- which is West 45th Street. (The Duane Reade node is slightly closer to West 45th Street.) That's my best guess.

(The "highway:secondary" thing just indicates how major a road West 45th Street is -- it doesn't mean that it's a second road that's associated with the Duane Reade POI.)

So I'd say try changing the addr:street from "Fifth Avenue" to "5th Avenue" and see if that fixes the problem. (Note that if the node is inside a building that itself has address tags, as this one does, you could also just remove all the address tags and it will inherit from the building it's in. This is a nice shortcut for POI nodes in single-address buildings.)

Good luck, J

68626909 over 6 years ago

All fixed, don't worry about it a bit. We all make mistakes; I've probably made hundreds. See this Q&A for background:
https://help.openstreetmap.org/questions/1022/what-are-the-most-common-mapping-mistakes-that-other-users-make

Regarding disaster management -- I'm not really up on that, but maybe the Humanitarian OSM Team project would be of interest to you?
osm.wiki/Humanitarian_OSM_Team

68626909 over 6 years ago

Hi DMcCo, welcome to Openstreetmap!

I'm a mapper active in NYC and I'm examining the changes you've made because you requested that they be reviewed.

The bicycle shop you added as this node:
node/6367677379
was already on the map, tagged as occupying the whole building:
way/248238789

I'm going to go ahead and combine the two so the shop is not double-mapped. One question -- the opening hours you added are different from the ones listed for the building. What's your sources for these hours? Do they come from a sign on the premises? From a website?

Let me know if you have any questions, I'm happy to assist or advise.

Thanks, jmapb