alester's Comments
| Changeset | When | Comment |
|---|---|---|
| 66743065 | almost 7 years ago | This is another changeset that required quite a bit of cleanup. This included more foreign tags that should have been removed, untagged nodes and ways, duplicated objects, and incorrectly deleted link ways. Please reply to this comment to acknowledge that you're reading these comments, because I'm seeing the same issues continuing to occur. Also, please try not to mass-delete and replace objects, and instead modify existing objects when possible. |
| 66716644 | almost 7 years ago | The Salt Spring Saturday Market doesn't have a permanent building, so I removed the building tag and fixed the opening_hours |
| 64250521 | almost 7 years ago | Hi Robert. Sorry, I missed seeing this comment earlier. A number of the multipolygon relations in this area had small no-man's-land gaps between separated outer ways with a natural=ridge way running in between, rather than sharing ways. I modified these to use the ridge ways where applicable as the outer ways, shared by adjacent relations. This eliminates the small gaps where nothing was tagged. I believe there were also a number of small untagged ways inside these gaps, which I couldn't see a reason for and removed. |
| 64249727 | almost 7 years ago | Hi Robert. Until the trees grow up to a reasonable height, the land in those areas best fits a "scrub" description (ie. low bushes and trees). While maybe not perfect, this is the best fit within the current set of typical OSM landuse tags. These were previously tagged as industrial, which certainly isn't correct for a remote logged area of land with no industrial activity after the relatively brief initial harvesting period. If it's a relatively short time until the area looks like forest again, then it might be best to just not exclude them from natural=wood multipolygons so they're mapped as natural=wood. I may think about doing this for some other logged areas on the south island. |
| 66670027 | almost 7 years ago | I cleaned up after this changeset and your other previous ones in the area. This included removing foreign keys that were left on imported objects, removing untagged objects, and fixing tagging on various objects. Please make sure you use the JOSM validator to fix these issues before uploading. I'll be going for a walk today to verify the existence (or lack of) of the supposed fences in this area. |
| 66416311 | almost 7 years ago | This has left the area in a bit of a mess with overlapping and untagged relations and fences where there definitely aren't fences. The Mary Hill military area also now extends much farther than it does on the ground. I've looked at the parcels in the past, and they simply don't match up with what's happening on the ground with regard to Pearson College and the Mary Hill area. The previous state in OSM was the best ballpark I could come up with to reflect the on-the-ground reality. I think the long "finger" of Mary Hill that now extends to the north of the college and across the Goose at least needs to be removed, because that definitely isn't part of the military area, nor are there fences there. The various "parcel" relations in the area also need to be cleaned up and merged with the coastline where applicable. |
| 66065502 | almost 7 years ago | What source did you use for this? Both BC provincial park data and CRD data shows the Gowlland Tod boundary meeting the Cal Revelle boundary at a right angle like it did before, not at an angle like this. |
| 66013489 | almost 7 years ago | Whoops, never mind. I see you reverted the name back a little while later. Sorry. :) |
| 66013489 | almost 7 years ago | I'm curious why you swapped these names. The source stated on the changeset is GeoBC, but they use Saltspring, not Salt Spring. The BC Geographical Names database (http://apps.gov.bc.ca/pub/bcgnws/names/13666.html) also uses the 1-word form. Since local usage is fairly evenly split between the two forms, it makes the most sense to use the name considered official and used by the government. |
| 65570633 | about 7 years ago | Please don't create fictional data in the OSM database. You should use the sandbox database or set up your own database for testing. I've removed the fictional data around 0,0 |
| 65538097 | about 7 years ago | Can you please explain what the source of your changes was? It seems like you changed some populations based on some unknown source, and incorrectly changed the place type of a few places. ...and I agree that meaningful changeset comments would be greatly appreciated.
|
| 65490961 | about 7 years ago | This is a sports field, not just a grassy area, so I've changed this back to leisure=pitch |
| 65024854 | about 7 years ago | The general rule is that the name used "on-the-ground" and/or the one most commonly known by locals should be the one used in the "name" tag. This would be Mount Newton, so I've restored that name to the "name" tag and tagged ȽÁU,WELṈEW̱ under "name:sal" (the closest related language code to SENĆOŦEN) |
| 64637020 | about 7 years ago | These seem to be based on Wikipedia location data, which I believe isn't compatible with the OSM licensing requirements because that data could be sourced from proprietary sources like Google. It seems to be of questionable quality anyway, such as the CILS transmitter being in a house's backyard. |
| 64587418 | about 7 years ago | Their map labels the greenspace running through this area as a "central greenway", but that isn't the actual name of the park. The name Meadow Park has been used in many places, including by the City of Colwood and the developer building the homes around it. I've restored the name Meadow Park |
| 64118418 | about 7 years ago | In a way. After I noticed some edits in the Greater Victoria area that caused a bunch of damage, I now use a tool to watch for any edits in the area and look to see what was being done. Most of them are harmless and make positive changes, but sometimes there's something that gets broken, doesn't make sense, or could be done in a better way. I try to comment on those or just fix them. In this particular case, I work on the same block as Chapters, so the Starbucks change was something that jumped out to me. There are lots of stores in Greater Victoria and they're constantly changing, so it would be great if you could change anything that you've noticed has changed on-the-ground. I'll try not to inspect your edits in too much detail. :) |
| 64118418 | about 7 years ago | OK, the move of Starbucks must have been accidental. I've since confirmed that the Starbucks closed when Chapters moved out, so I removed it entirely |
| 64180934 | about 7 years ago | These substations shouldn't have any addr:* tags if they don't actually have a street address. is_in tags are also unnecessary. Any with a name of "Nova Scotia Power" should have that removed, because that's the operator, not the name of the substation |
| 64154216 | about 7 years ago | This is a good start, but don't forget to also make the following changes:
|
| 64118418 | about 7 years ago | Didn't the Starbucks close at the same time as Chapters? Even when it was open, it was at the front corner of Chapters, not in the back and shared with Shoppers. |