OpenStreetMap logo OpenStreetMap

Changeset When Comment
81166296 almost 6 years ago

Yep, it's good to map them individually, with fitness_station=* on each of the nodes, but then just a single leisure=fitness_station. This is more in line with the wiki recommendation and osm.wiki/Good_practice#One_feature.2C_one_OSM_element. It means data consumers can know there is 1 fitness station here with multiple equipment.

81166296 almost 6 years ago

See leisure=fitness_station.

"Similar to playground equipment, individual exercise equipment within a fitness station should be mapped individually as separate nodes inside the fitness station area using fitness_station=* for the equipment type.

Alternatively it is acceptable to describe the available equipment on the leisure=fitness_station object with prefix-tags in the format fitness_station:<equipment_type>=yes."

So there should only be one leisure=fitness_station.

I've fixed this in changeset/81202581

81188673 almost 6 years ago

Which maproutette task is this.

The relation is the top level feature for the suburb relation/5682414 and already has the wikidata, it's easier to maintain if we avoid duplicating this on the label node.

79940229 almost 6 years ago

I haven't been here and don't have the local knowledge, but from what I can see from the aerial imagery it looks perfectly mapped now, and when comparing with the LPI Basemap it looks contained within the two lots of the park.

79344998 almost 6 years ago

> The Krauts map amenities as node primarily. Additionally the surroundings may get building=fire_station; landuse=commercial but they do not carry further information like branch or telephone numbers.

We'll here we map as accurate as we can and try to map what's on the ground. Usually fire stations have grounds where buildings are located, equipment is located and trucks are parked so it's a more accurate model of reality by using an area for the amenity=fire_station than an arbitrary node.

79940229 almost 6 years ago

I agree with Hb- here, we should map what's on the ground, the park in OSM should match where it exists on the ground, not where the legal boundaries are, which is in link with he good practice guideline Hb- pointed out.

80903514 almost 6 years ago

Thanks for explaining the background of this edit. I think it's okay if you see a photo or read a book which hint you to look at a particular area in OSM that might need updating, however it was pointed out that the fence is not visible on imagery, so how are you determining the exact geometry to use?

80643127 almost 6 years ago

Hi @vakulya Given the license of the source you've used for this data isn't compatibale with OSM I've reverted the admin boundary in changeset/81089443/.

Please next time don't import data from sources incompatible licenses and if in doubt feel free to reach out to the local AU community on the talk-au mailing list.

I'd also like to point out an import of admin boundaries is planned in osm.wiki/Import/Catalogue/PSMA_Admin_Boundaries

81061082 almost 6 years ago

If you're planning on importing this data can I ask you put together some notes in an email on talk-au or on the OSM wiki so we can discuss this please?

For example I noticed here you have "surface" and "suface".

Regarding difficultly I don't think this should be included unless there is some documented guide on how to determine the difficulty. My guess is it has been assigned automatically based on infrastructure class so there's no benefit of including it in my opinion.

Lastly I'd omit the ref, is there any use for it?

81061082 almost 6 years ago

Where's the OSM discourd server #asia-pacific channel?

I went to osm.wiki/Discord_servers and joined the International one but I can't see any #asia-pacific channel.

81061082 almost 6 years ago

Absolutely, it's why I advocate against doing an import of this data. What I do think it is useful for is identifying areas which are different which may indicate an error in OSM (or in TfNSW data) and then we go and check those via imagery/mapillary/ground survey to see if OSM needs updating.

So far I haven't noticed anyone else bring this data in (except for a brief spell where a person from TfNSW was using this data to update OSM. Some of that ended up getting reverted due to data quality).

81028183 almost 6 years ago

So generally the LPI NSW Imagery is created to a higher positional accuracy than other satellite sources, so it's usually best, however nothing is perfect and it will shift between imagery updates so generally if it's a long way off feel free to improve, but if it's close I wouldn't normally bother.

Since OSM doesn't support a dynamic datum and since the whole continent is moving, every day the coordinates entered in OSM are slowly drifting away from reality about 1m every 10 years so

81028183 almost 6 years ago

At some point we'll do an import using TfNSW data, but we're not there yet. If there is a printed timetable it usually has the bus stop name at the top.

81028183 almost 6 years ago

hi, the number is the ref=* for the bus stop, not the name, the name is usually the street name etc.

81030331 almost 6 years ago

Just a tip, when adding wikipedia links you need to also specify the language code of the page. I've done this for this feature see https://osmlab.github.io/osm-deep-history/#/way/4631838. If you add it with the iD editor it should do that automatically if you select from the dropdown, it should also add the wikidata id.

37337541 almost 6 years ago

I've edited way/23565958 now to reduce the area.

81061082 almost 6 years ago

yep that's fine thanks. Just keep an eye out when using the data as it sometimes may be outdated.

81040885 almost 6 years ago

did you mean to leave the name as pp? If it's underground you might want to use tunnel=culvert or location=underground

81061082 almost 6 years ago

If you're using TfNSW cycleways data then per the waiver agreement osm.wiki/File:TfNSW_OSM_CCBY_Signed_Waiver.pdf we need to provide attribution at osm.wiki/Contributors#New_South_Wales_Government_data Can you add the attribution for the original source used to the Contributors wiki page please?

37337541 almost 6 years ago

Agreed it's not military, that's why I just deleted the landuse=military tag, while retaining military=danger_area in changeset/81056371. The wiki page confirms that military=danger_area doesn't imply related in any way to the military. I know it's not the best tag being military= but it's the best one that I'm aware of which is documented and in use.

I'd very much welcome more work on a better tag for general projectile or weapons danger areas, but in the meantime I don't think it's warranted to have the pitch the way you changed it here. I'd rather change it back to the smaller area.

In my mind the danger area and the pitch are two different things, one being the larger area and one much smaller where the sport is actually practised on.