OpenStreetMap logo OpenStreetMap

Changeset When Comment
147363117 10 months ago

way/1249459181

man_made=water_works is "a facility where water is treated to make it suitable for human consumption before being sent to the water network." per the wiki.

However the building is labeled "SPS", which is per osm.wiki/Sydney_Water a Sewage Pumping Station. A water_works (water treatment plant) would be WT.

I've since added this detail to the building at way/1249459180 so I'll just leave the landuse but remove water_works.

162481034 10 months ago

The Curve and Gradient diagram has unclear copyright and per osm.wiki/Australian_Data_Sources#New_South_Wales we don't feel comfortable using it directly as a data source.

162485024 10 months ago

Possibly these buildings should have ref=A through ref=K?

162035159 10 months ago

hi the traffic cabinet was already mapped at node/12470392128 and you've added a duplicate, I'll add your new tags to the existing node.

160197055 10 months ago

Firstly I value local mappers and everything to do with this import was done in consideration of how it would impact mappers, the intent was to support local mappers and minimise disruption and grief. So I'm disappointed that you feel otherwise.

You don't need to be active on the community forums, but at a point we need to collaborate as a community, you don't need to partipate, but if you don't then you may miss out on an opportunity to shape the project direction.

The Community Discussion points were documented at https://gitlab.com/alantgeo/vicmap2osm/#community-feedback with most of the discussion happening in the thread at https://lists.openstreetmap.org/pipermail/talk-au/2021-May/014622.html

You're welcome to take this up with the DWG, of course I welcome any review of my work on this import, at all times I've tried to balance all community feedback and points raised. The vast majority of feedback I've recieved has been positive, but I do understand you feel this import missed the mark for you. In a broad community, not everyone will be happy.

Regarding your specific issue, you're arguing that addresess should have been added to existing buildings rather than as nodes, and that's you're only issue? Take it up on the community forum, and we can have a discussion there.

But regardless I'm still not seeing how the integrity of the data in OSM is compromised by this import. It didn't delete any existing addresses, and mostly didn't add any duplicates, or even modify existing ones even when Vicmap data disagreed with what was in OSM.

A valid option from the community could have been "no we don't want this data imported, we'll keep adding addresses by survey only" however this was not what I heard from the community, I head that an import is best.

If you want to do an automated edit to merge these address nodes onto the buildings, then please as an automated edit please post your plans and methodology to the community forum for review and discussion.

162375413 10 months ago

See destination=*

`destination`=* should go on the road you turn into, not the road you turn from, but it only really works when there it's not different from each of the from roads, and even then it's usually for a place not a street (see destination:street=* for that). On the first wiki page you can also see there is destination:lanes which can be set per-lane on the from way.

However there is yet another method (first was destination on the to way, second was destination:lanes on the from way) which is use a relation, which exists here at relation/10699075/history this can capture more detail about the destination sign.

161725061 11 months ago

No worries, I didn't look back to see it was building=building before.

skyscrapercenter.com is a database, which holds a vast collection of information about buildings, they consider this their proprietary data and while their terms mention "public use" after I asked them about use in OSM they clarified that commercial use of their data is not permitted. Since OpenStreetMap publishes data under the ODbL license which does allow commercial use, we can't use their data at all. That's why I removed those tags because it was all copied from that website.

What someone needs to do is go survey this building and measure the height and count the number of levels, and see what's there, is it offices, residences, then use that survey to re-add that information.

158917740 11 months ago

As an update I've finished reviewing all your prior edits and have reverted either fully or manually the data I strongly believe or you have stated to have been copied from the CTBUH proprietary database.

112567595 11 months ago

manually reverted in changeset/162301634 to remove proprietary data

89770128 11 months ago

also in changeset/162301618

89770128 11 months ago

This changeset has been manually reverted in changeset/162301600 to remove all proprietary data added.

74214901 11 months ago

hi as recently extensively discussed in changeset/158917740 skyscrapercenter.com is not an acceptable source for use in OSM. I reached out and they confirmed no commercial use is permitted, so it's definitely a no for OSM. I've had to revert a whole bunch of these added already due to this and it's causing some mess, but we need to ensure we have a 100% clean dataset in OSM from a licensing point of view.

I know you're very extensively been mapping buildings in Sydney, so can you please confirm if you had added any other data from the proprietary skypscrapercenter.com database?

83505667 11 months ago

hi as recently extensively discussed in changeset/158917740 skyscrapercenter.com is not an acceptable source for use in OSM. I reached out and they confirmed no commercial use is permitted, so it's definitely a no for OSM. I've had to revert a whole bunch of these added already due to this and it's causing some mess, but we need to ensure we have a 100% clean dataset in OSM from a licensing point of view.

I know you're very extensively been mapping buildings in Sydney, so can you please confirm if you had added any other data from the proprietary skipscrapercenter.com database?

110373745 11 months ago

Partially reverted in changeset/162301440 to remove building height as this was likely sourced from proprietary data.

161725061 11 months ago

building=skyscaper is not a tag in common use (<20 uses) and not documented on the wiki, nor have I seen any discussion on the tag.

In general I don't think this is a good idea, as "skyscraper" is hard to define, you'd need to pick an arbitrary height and then you may as well just set the height=* tag directly. Furthermore it removes the ability to define what kind of building it is, eg. residential tower or office building.

110373947 11 months ago

This changeset has been reverted in changeset/162301270 due to the use of proprietary data.

110399130 11 months ago

This changeset has been reverted in changeset/162301234 due to use of proprietary data.

148525724 11 months ago

This changeset has been reverted in changeset/162275879 due to use of proprietary data.

148897119 11 months ago

This changeset has been reverted in changeset/162275655 due to use of proprietary data.

149375010 11 months ago

This changeset has been reverted in changeset/162275567 due to the use of proprietary data.