aharvey's Comments
| Changeset | When | Comment |
|---|---|---|
| 128972087 | about 3 years ago | reverted in changeset/129039096 I've retained some of the later conflicted changes around Market Street being split into two oneways. |
| 128979610 | about 3 years ago | Actually I couldn't find any sidewalk=yes on highway=footway in your edits here. So based on the issues raised, I've reverted this changeset in changeset/129037612 I will note that it looks like many of these changes to were to address JOSM Validator issues. The JOSM Validator is strongly opinionated and flags many things which are commonly accepted mapping practices here. |
| 128979610 | about 3 years ago | Sorry just on my previous post, I see you've done both, so while sidewalk=yes on the highway=footway doesn't make too much sense, you've also removed it from some other road highways. |
| 128979610 | about 3 years ago | > highway=footway and sidewalk=yes does not make sense. Agreed, but your changes remove sidewalk from road ways, not highway=footway. |
| 128972087 | about 3 years ago | Spot on Ds5rUy. While it's reasonable for data consumers to assume no as a default value, sometimes mappers will map it to be explicit if they have checked. Sometimes it might be easily mistaken as oneway=yes by armchair mappers so we'd add oneway=no to avoid it being tagged without a survey. Generally a good idea to try and split the changeset into similar changes as it makes it easier in cases like this. |
| 128979610 | about 3 years ago | Honestly I can't see anything in this changeset we should keep and would suggest we revert it. |
| 128979610 | about 3 years ago | Hi Reiner, Reviewing your changeset, you've removed footway=sidewalk from the separately mapped highway=footway. It was correct beforehand so this will need to be restored. Separately mapped footpaths (highway=footway + footway=sidewalk) can coexist with the sidewalk tag on the road way, and in my opinion it's better to do both. sidewalk=*#Separately_mapped_sidewalks documents how you can mark it as exists and separately mapped if you want (sidewalk:left=separate + sidewalk:right=separate) but personally I'd still just do sidewalk=both. The crossings were mapped as ways with highway=footway + footway=crossing, which is what you've removed, so your comment about highway=crossing on nodes doesn't seem to apply to your changes. Keep in mind that the established and community tagging practices do vary a bit in Australia compared to Germany, we've documented this at osm.wiki/Australian_Tagging_Guidelines/Cycling_and_Foot_Paths here we will use highway=cycleway + foot=designated + bicycle=designated for shared paths and guideposts or markings are sufficient to indicate =designated. |
| 128705556 | about 3 years ago | You can see the changes at http://osmlab.github.io/osm-deep-history/#/way/30738624 |
| 128705556 | about 3 years ago | Hi and welcome to OSM. Further to my comments on your note. The access=no tag shoudn't be set since generally the public can access this bridge. From what I could see on albit outdated imagery there is no special pedestrian or bicycle signage, therefore bicycle/foot shouldn't be designated. Also the name should be the street name, bridge name can go under bridge:name=*. |
| 126038894 | over 3 years ago | Hi Milk Point, TomTom is not a compatible data source so we'll need to revert these changes. Further there is a community consensus around many of these name=* values not actually being names but rather descriptions (description=*) or destinations (osm.wiki/Relation:destination_sign) which are generally mapped using other tags and not as the name=* tag. If you don't think that's right please post back and join in the discussion, but otherwise in line with the community consensus these changes will be reverted. -- aharvey, on behalf of DWG. |
| 125386716 | over 3 years ago | "...so long as these documents are not offered for resale..." OSM's license allows for OSM data to be offered for resale, therefore the Metromap Terms of Use are not sufficient to use their imagery to derive data for inclusion in OSM. |
| 118216860 | over 3 years ago | highway=track is for roads, these aren't roads, they are mountain bike tracks. But yeah highway=track doesn't imply quality of which vehicles that can use it. These already had mtb:scale:imba, but that alone can't be used to tell if it's a mountain bike track or not. |
| 124090577 | over 3 years ago | what's your source for the building type changes? |
| 118216860 | over 3 years ago | highway=track is for "Roads for mostly agricultural or forestry uses." (highway=*) ie. for roads which you can drive a motor vehicle on. This is a single path track constructed for mountain bike use so highway=cycleway is best in my opinion, but I understand that cycleway is contentious, as an alternative we can use highway=path + path=mtb. I've added the path=mtb and restored to cycleway for now. |
| 122245893 | over 3 years ago | The bicycle access and highway classification are two independent settings. https://www.mapillary.com/app/?pKey=543018103351921&focus=photo makes it abundantly clear that bicycles are only forbidden from that point onwards, so bicycle=yes can still remain up until that point. The issue that bicycles have no where to go/exit at that point is one routers solve and not something we should address in bicycle=* tagging. I agree that the distinction between motorway_link and trunk here is debatable, but due to the length and service road joining Batman Avenue I would lean in favour of trunk until the tollway entrance sign. |
| 59756186 | over 3 years ago | Hi I realise this is an old change but what source/justification did you have for creating a bridge at way/596670708 ? Footways crossing waterways could be a bridge, or the waterway could be a culvert, or it could be a ford (creek crossing). Without a survey or very good imagery it's impossible to know. In this instance it's very unlikely to be a bridge and likely just a ford (creek crossing). Since it looks like you've done this as part of a coordinated effort at Kaart (?), how widespread is this, were there other similar changes? |
| 120119176 | over 3 years ago | I also restored the deleted inner way from https://osmcha.org/changesets/120119176 which represented that this ridge area is excluded from the tree cover area from the Bing imagery that looks roughly okay. Unless you know that this area is covered with trees and you really did intend to delete it? |
| 120119031 | over 3 years ago | Hi welcome to OSM. In your edit here it looks like you've accidentally tagged the trees landuse multipolygon as a lake instead of the around the lake area that you improved the geometry for, you can see your changes at https://osmcha.org/changesets/120119031?filters=%7B%22users%22%3A%5B%7B%22label%22%3A%22markw11%22%2C%22value%22%3A%22markw11%22%7D%5D%2C%22date__gte%22%3A%5B%7B%22label%22%3A%22%22%2C%22value%22%3A%22%22%7D%5D%7D. I've fixed it by placing the lake tags on the proper area and restored the trees landcover tags. |
| 120236037 | over 3 years ago | I added the turn:lanes tagging and tweaked a bit per Maxar imagery which appears to show more recent changes to lanes changeset/120374112 |
| 117942944 | over 3 years ago | It looks like you've added a driveway for the full admin boundary here at note/3157838#map=19/-38.01944/145.39789 did you mean to just map the driveway next to it? |