OpenStreetMap logo OpenStreetMap

Changeset When Comment
116450444 over 3 years ago

How do you know that the surface of the bridge is concrete?
---

Published using OSMCha: https://osmcha.org/changesets/116450444

117747272 over 3 years ago

Thanks for cleaning up. The value you put in name might be better in official_name, though.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117747272

117787626 over 3 years ago

Hi, welcome to OSM!

Are you sure this is a house? It's pretty small in comparison to the other main building on the property.
---

Published using OSMCha: https://osmcha.org/changesets/117787626

89315416 over 3 years ago

Hi, you created a bad route relation in this changeset. Please take a look at relation/11497509 and correct it as needed. Thanks

61035468 over 3 years ago

Just letting you know, you somehow created a new relation for I-865 in this changeset that only had one node in it. I'm deleting it now.

118926688 over 3 years ago

Overall looks good, just a couple things I wanted to point out.

First of all, I'd recommend using the "NYSDOP Orthoimagery - Latest" imagery source when editing in the state. It's the most consistent imagery source, although some other sources (Mapbox, Bing) can have higher resolution in some places. I've seen imagery glitches in both Bing and Mapbox in some places, so I tend to only use them if I need higher resolution in certain places. Even then, I offset those sources to match the NYS imagery.

Also, if some paths through parking lots are a sort of "main" path (even if there are parking spaces on both sides), you can omit the parking aisle tag, which conveys their significance. It will stand out on the map and be preferable to nagivation apps.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/118926688

118782008 over 3 years ago

Hi,

Where are you getting this address information? This is Amherst, not Buffalo.
---

Published using OSMCha: https://osmcha.org/changesets/118782008

116971729 over 3 years ago

I see now that you didn't just delete the turn restriction, you just deleted the old one and made a new one with the restriction "only_straight_on".

First of all, please don't delete and remap when possible. Try to preserve history. But also, I would say that only left turn is correct here, since traffic is turning left.

Continuing with revert.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/116971729

116971729 over 3 years ago

Hi,

First of all, it was fine as it was. Adding curves where there isn't any just to satisfy your QA tool isn't in the best interest of the map.

Second, why did you delete the turn restriction? Now, routing will allow U-Turns at this intersection.

Reverting.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/116971729

117254521 over 3 years ago

Actually, now I see that those letters in the trail names actually refer to the color of the trail blazes. This is not the right place to put them, however.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117254521

117254521 over 3 years ago

Good edit, but the changeset comment doesn't match what you changed.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117254521

117259046 over 3 years ago

This is an interesting park. It seems like each of these trails have both a name and an assigned letter. I think that putting the assigned letter as a ref might be ideal here, I might come through and change it to this. For example, this trail would be tagged like: `name=Woodlands Trail` `ref=Y`.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117259046

117258994 over 3 years ago

Hi,

Thanks for trying to fix this, but by having the bridge connected to the stream with a node, you're basically saying that they're connected to each other at the same level. Please try not to do this.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117258994

117257600 over 3 years ago

I'm not sure that these are good reasons to outright remove a trail. If it's at all possible to walk on, I'd leave it on the map but discourage its use with other tags.
---

Published using OSMCha: https://osmcha.org/changesets/117257600

117895636 over 3 years ago

Hi,

Where did you get the address information from? Is "Crossroads Plaza" a real street?
---

Published using OSMCha: https://osmcha.org/changesets/117895636

117827885 over 3 years ago

Great job! If you could split up your changesets slightly, it would be easier to review. Maybe do the yard in one changeset and the line in the other? Either way, not a big deal, changeset looks good to me.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117827885

117543294 over 3 years ago

By the way, I only reviewed bad because there was that significant issue with the school. I still appreciate the contribution.

117543294 over 3 years ago

Hi,

Since you requested review, here it is. You did well on mapping the house; I appreciate you moving the tags from the node to the new building. However, other imagery sources are much better here, so you could have mapped more accurately if you used those. Make sure to review your imagery options for each area you work on.

However, mapping the school as a building where the way goes around the perimeter of the premises is not quite correct. You're saying that there's building even in the open spaces on the inside. If you can't fit one way all the way around the building pieces, you can use a multipolygon. See this page: osm.wiki/Relation:multipolygon
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117543294

117449849 over 3 years ago

Hi,

How do you know what the surface is here? I doubt you visited in person based on the changeset type. Also, you have to add a layer tag when making bridges.
---

Published using OSMCha: https://osmcha.org/changesets/117449849

117696154 over 3 years ago

Hi,

Please check multiple imagery sources available to you when mapping. The one you were using probably wasn't very useful here, so you had to put in a rough shape. Other imagery sources here are much better, so you could have mapped the building more accurately to what's on the ground. Either way though, thanks for contributing!
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117696154