OpenStreetMap logo OpenStreetMap

Changeset When Comment
135481807 almost 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Looks great overall, one minor thing is that it's best to be as specific as possible - in this case that means saying surface=asphalt rather than surface=paved. (The latter could mean asphalt, concrete, etc.)

Thanks again and welcome to OSM!

135932047 almost 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes.

- The Description tag should be a concise description of the feature rather than a free-form ad space.
- Opening hours tag follows a specific syntax. It can be a little tricky but using this format makes it machine-readable, meaning apps and whatnot can parse it reliably.
- In your changeset description, you should say what modifications to OSM data you made.

I went ahead and fixed those issues. Thanks again.

146035162 almost 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Looks good to me, as long as you have a good source. Thanks for your contribution!

145739867 almost 2 years ago

Any reason to add piste ways directly on top of existing ways like roads? In my experience, it makes it way harder to improve the map when doing non-ski stuff. Why not put piste tags onto existing ways like roads and trails? Doing some research, it looks like overlapping ways is considered an error by multiple QA tools [1] [2] but I'm of course open to discussion on why it might be better for pistes. Let me know what you think!

[1] osm.wiki/Keep_Right/200_overlapping_ways
[2] osm.wiki/JOSM/Validator

145595245 almost 2 years ago

Thanks for the updates!

143933492 about 2 years ago

Removed as spam.

145260186 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Looks great to me, no problems. Welcome to OpenStreetMap!

145204587 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Everything looks good to me. Thanks again!

144401248 about 2 years ago

Thanks for the info Allison. (See my comment on that other changeset.) I disagree with you on requested review - I noticed recently that the majority are legitimate edits from new mappers, and the vast majority never get reviewed by anyone. (At least not publicly.) Also, most SEO spammers do not ask for review.
That's why I've been trying to go through and welcome new mappers, give them constructive feedback.

If a small business owner follows some instruction article on how to add to OSM, and gets bad advice making their edit appear spammy, I don't want to just silently revert it without contacting them - leaving a bad taste in their mouth about OSM.

143933492 about 2 years ago

Like I said I was pretty sure this is SEO spam (it seems that many businesses added by brand-new accounts are). The bad thing is that I don't know how I can be 100% sure it's not legitimate. I want to give people the benefit of the doubt so I've been asking them in a comment, then marking it in OSMCha to go back later and remove if they don't reply. Maybe you're right that I'm wasting my time though...

145167732 about 2 years ago

Got er fixed!

145019609 about 2 years ago

I went over your other recent changes too. Looks great to me! Thanks for your additions - this is valuable info!

145023098 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Everything looks good to me! One very minor thing you may want to change - it's best to be explicit for every day of the week on opening_hours tag. That means putting the days the office is closed too. (Mo-Fr 08:30-17:30; Sa-Su off)
Thanks again and happy mapping!

145167732 about 2 years ago

Oh geez. I'm not too familiar with revert tools so looks like I just removed Upper Wasabi as a conflict. Let me just do it in JOSM when I get home, haha. Sorry about that.

145167732 about 2 years ago

Gotcha. No problem! There are tools to revert changes like this. Looks like any geometrical adjustment you made was lost (since the deletion was in the same changeset as any geometric changes), so you'll have to start over on that I think. But we can un-delete it. :)

145023263 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Looks like a few things are wrong here:
- You removed highway=* tags from a couple roads. Those are necessary to mark things as roads. Looks like another mapper already fixed your Twain Ave removal.
- It seems like the towing company you added might be misplaced or spam. Can you give a source that this is really accurate info? (In-person survey is a valid source.) If this is your business that you run from your home, it's debatable whether the info is appropriate for OSM. Perhaps a relevant test might be, if someone showed up here, could they be served in-person?
- The Description tag should be a concise description of the feature rather than a free-form ad space.

I fixed what I could here. Let me know what you think about the placement thing. Thanks again and happy mapping!

145031294 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Looks good to me, no complaints!

145050902 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Everything looks good to me! Thanks again and happy mapping.

145097633 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Looks good overall, here are a couple of minor issues:
- Ways should generally be connected wherever it makes sense that one could travel between them. That means the path should connect to the highway somehow even if seems a little wonky.
- For something like this parking lot, if it's signed or officially labeled somehow as Pete's Pile Parking, name=* tag is best. However, if that's more of a casual name that the locals might refer to it by, the loc_name=* is better.

I went ahead and made those changes. (OSM can have somewhat of a wild west attitude to certain things... So not everyone might agree on my ideas. But I do my best to follow generally accepted best practices.)
Thanks again and happy mapping!

145099094 about 2 years ago

Hi, thanks for your contribution! Since you requested a review, I looked over your changes. Everything looks good to me! One minor thing you may want to change - it's best to be explicit for every day of the week on opening_hours tag. That means putting the days the office is closed too. (Mo-Fr 09:00-17:00; Sa-Su off)
Thanks again and happy mapping!