Xvtn's Comments
| Changeset | When | Comment |
|---|---|---|
| 147626687 | almost 2 years ago | For the playground map, my recommendation would be to remove all tags from the member ways, and keep playground=map; type=multipolygon on the parent relation. Anyway, like I said, everything else looks great! Micro-mapping can be really fun huh. Let me know if you have any questions, and thanks for your contributions! |
| 147626687 | almost 2 years ago | Hi! Since you requested a review, I looked over your changes here. Nice job on all the details here! Most everything looks great to me as far as tagging goes. The only issue I see is with the multipolygons. A really common mistake is to tag both the member ways (the outlines of features) *and* the multipolygon relation. Really only one of those options should have tags such as building=school or whatever. In this case, I'd say the best way would be to just remove the school building multipolygon, since I wouldn't consider all those shapes to be parts of one building - instead they are each their own building structure, if that makes sense. |
| 147996236 | almost 2 years ago | Yeah, I've been mapping a couple years now and still constantly fight with the syntax. The wiki's definition is indeed way too verbose. IMO, there is a real need for a "builder" tool where you can use a gui to describe the situation and it'll create the string for you. Maybe I'll make it someday haha. Until then at least we have parsers/validators like this. |
| 147747274 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes here. Looks great to me, no complaints! Regarding geometry, one resource you might be interested in to improve the trail is Strava's heatmap. It is a little bit of a hassle to make an account and get the cookie info, but once you do it's an awesome source of data for improving trails and whatnot. More info: osm.wiki/Strava Anyway, let me know if you have any questions, and thanks for your contributions! |
| 147599015 | almost 2 years ago | Hi! Since you requested a review, I looked over your changes here. Looks good to me, no complaints! Thanks for your contributions! |
| 147863240 | almost 2 years ago | Hi! Since you requested a review, I looked over your changes. Looks great to me, no issues I can see! Thanks for your contributions. |
| 147787141 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes here. Looks great to me, no complaints. Thanks for your contributions! |
| 147838302 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes here. Looks great overall - The only suggestion I'd give is to check the context as far as building outlines. In this case, looking at the roof, it looks like this is all one building structure, containing multiple businesses. Therefore I'd recommend keeping businesses as single nodes placed within the building. (As opposed to overlapping, conflicting building ways - not recommended.)
|
| 147915279 | almost 2 years ago | Hi! Since you requested a review, I looked over your changes here. Everything looks good to me, no complaints! Thanks for your contributions! |
| 147916958 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes here. Everything looks great, except that building:levels shouldn't be 0. It's my understanding that building:levels describes how many above-ground floors there are, so something like this should be at least 1. Let me know if you have any questions, and thanks for your contribution! |
| 147947525 | almost 2 years ago | I went ahead and fixed that house tag issue. |
| 147947525 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes here. Nice job on these houses - Everything looks great to me except the house=residential tag you've added. I don't think that's a valid value - here's some good info on the use of that tag. house=* Other than that, no issues! Let me know if you have any questions, and thanks for your contributions! |
| 147996236 | almost 2 years ago | Hi! Since you requested a review, I looked over your changes here. Everything looks good to me, the only suggestion I have is to remove the semicolon in opening_hours tag. That way, data consumers can parse "temporarily closed" as a comment referring to the `closed` instruction (as opposed to being some additional instruction.) Opening_hours can be really tricky, so for interesting cases like this I'll usually use this tool to make sure I've got it right: https://openingh.openstreetmap.de/evaluation_tool/?EXP=closed%20%22Temporarily%20closed%22&lat=48.7769&lon=9.1844&mode=0# Let me know if you have any questions, and thanks for your contributions! |
| 147997357 | almost 2 years ago | Hi! Since you requested a review, I looked over your changes here. Everything seems good to me. Thanks for your contributions! |
| 148000998 | almost 2 years ago | Great advice by Glassman. If I may add one clarifying thing (if it's not already obvious) - the access=* tag is understood to include (and override) all other access-type tags such as foot, horse, bike, etc. |
| 148031966 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes here. Looks good to me! Thanks for your contribution. |
| 147522988 | almost 2 years ago | Hi, and welcome to OpenStreetMap! Since you requested a review, I looked over your changes. Everything looks good - my only suggestion is that you should save your work before moving on to another area. When you edit in two completely different areas, the bounding box is huge. Let me know if you have any questions, and thanks for your contributions! |
| 147522988 | almost 2 years ago | Привет и добро пожаловать в OpenStreetMap! Поскольку вы запросили проверку, я просмотрел ваши изменения. Все выглядит хорошо — мое единственное предложение — сохранить свою работу, прежде чем переходить к другой области. Когда вы редактируете две совершенно разные области, ограничивающая рамка становится огромной. Дайте мне знать, если у вас есть какие-либо вопросы, и спасибо за ваш вклад! (Машинный перевод с английского) |
| 148045482 | almost 2 years ago | Hi! In the future, do you mind providing a descriptive changeset comment? That helps other mappers review your work. Here's some more info on good comments: osm.wiki/Good_changeset_comments |
| 147707615 | almost 2 years ago | Hi! Since you requested a review, I went over your changes here. Looks good to me, no complaints! Thanks for your contributions! |