Vincent de Phily's Comments
| Changeset | When | Comment |
|---|---|---|
| 47155042 | over 8 years ago | Curious about why you deleted the existing slipway to readd the (same ?) one. Just a mishap ? Looks like the slipway goes directly into the station building ? Map it this way then, no need to stop the way just before the building. Also, watch out for changeset comments that span multiple changesets. Each time you click "save" in iD you create a new changeset, so the changeset comment should reflect what you did since the previous time you clicked save, nothing before. |
| 47160720 | over 8 years ago | The shed probably isn't what caused a display issue (at least not preventing another building from showing up), so I'd say you should add it back. And if you know it's a shed, do tag it building=shed instead of the generic building=yes. |
| 47185367 | over 8 years ago | Seems like you replaced the multipolygon with a simple closed way to fix the rendering ? It works in the sense that the feature should now render as you expect, but you miss out on details that you had initially added. The better fix would have been to tag the multipolygon relation with the relevant tags (amenity=police, building=*, name=*...). See osm.wiki/Beginners_Guide_1.3 an especially the "relation" link. It's a great idea to try out different editors like you did. But Potlatch2 is a bit akward to edit relations with. |
| 46854141 | almost 9 years ago | Discussion started at https://help.openstreetmap.org/questions/55085/find-my-map but doesn't seem to be progressing. Welcome to OSM :) You'll need to add more tags to your object if you want it to be useful. What kind of a landmark is it ? Check osm.wiki/Map_Features and/or osm.wiki/Beginners%27_guide Also, remember that all data uploaded to OSM is public, editing the same database. For private maps, try for example osm.wiki/UMap . If "Landmark Learning" isn't a mappable real-world feature, please go ahead and delete it. |
| 46369577 | almost 9 years ago | That didn't quite fix it :p Both relations still included a lone chunk of the R759, and lacked roles on some members. Fixed in changeset/46371835. As an aside, I'm not sure what to do with way/475267656 : looks like a stream in Bing, didn't spot a boundary there in various OOC sources, but the way it's connected hints at a boundary. Is it just a stream ? |
| 46337978 | almost 9 years ago | All good :) I've been working away at OSMI's area checks for a few days, I hope to get Ireland all cleaned up, Wicklow and all. Note that the osm2pgsql devs have announced their intent to become a bit stricter in the polygon errors that they auto-correct (https://lists.openstreetmap.org/pipermail/talk/2017-February/077544.html), so an invalid polygon might render correctly today, but not in the future. |
| 46337978 | almost 9 years ago | Sorry, didn't mean to rush things. I commented using this recent changeset but the first breakage I looked at was a few days old. relation/4167050 (just one example found via OSMI) is a boundary in Wicklow edited 7 days ago and still broken. Making mistakes is part of mapping, I make plenty myself. Just wanted to attract your attention to these recurring ones, in case you missed them and/or to think whether some workflow change could help avoid future ones. Changing editors is a rather drastic workflow change, so maybe something can be done with Potlatch instead. |
| 46337978 | almost 9 years ago | Howdy :) Be careful with your boundary edits : you're leaving a trail of unclosed rings and role-less members (I'm just after fixing a few in bray/greystones). You can view some of the issues (various levels of importance) at http://tools.geofabrik.de/osmi/?view=areas&lon=-6.22295&lat=53.15156&zoom=10 or http://osmose.openstreetmap.fr/en/byuser/?username=Dafo43 (don't fret at the number of osmose errors attributed to you: they're attributed to whoever touched the object last, not who introduced an error). You can probably blame Potlatch for making these mistakes to easy to happen and go unnoticed. I'm sure you considered switching editors before ? We'd be happy to handhold you through the transition if necessary, just go on IRC or PM me. JOSM is great for boundaries, but iD works too. |
| 46249009 | almost 9 years ago | Some buildings geometries were messed up, especially the Educate Together school, so I fixed that. But I used some guesswork as to the proper location of the school, can you check it if you have local knowledge ? |
| 46166588 | almost 9 years ago | Welcome to OSM :) Some suggestions about tagging: * internet_access:fee=wlan doesn't make sense, I guess you meant internet_access=wlan, internet_access:fee=yes ? See internet=* access * level=4-5 should be level=4;5. Also make sure that you didn't actually want building:levels=* * I'm sure the hotel accept payments other than bitcoin, tag them. If a common payment method is not accepted (cheques ?), tag them too. Think of what information is useful, not what tag will get you listed where. * addr:city is not needed when the place is within the bounds of a city relation, which is pretty much always the case in Germany |
| 45715233 | almost 9 years ago | See also discussion in note/483610 |
| 45651105 | almost 9 years ago | Hurray for house numbers, and nice to see a Kilkenny mapper :) Note you can also use osm.wiki/Relation:associatedStreet instead of addr:street=* . I prefer the former but opinions vary on which is best and you should at least be aware of the alternative. |
| 45000391 | almost 9 years ago | Watch out, no motorway here ;) |
| 43668529 | about 9 years ago | Hum, why single out william street when all those parallel streets are similarly narrow ? It's actually reasonably wide compared to the rest. And the narrowest bit is actually the westmost 4 meters (see mapillary), which you didn't tag narrow ? I'm not a big fan of the 'narrow' tag (not very informative imho), what about lanes=1 and width=* ? |
| 43156250 | about 9 years ago | BTW in case you're wondering, there's no such thing as a "reviewer role" in OSM. Any OSM contributor can look at and comment on changesets. There are some people (like me) who look at newbie or suspicious changesets, and anybody stumbling uppon strange data will/should check the object history in the area. |
| 43156250 | about 9 years ago | You can't change the initial comment after the fact, but you can add additional comments to any changeset like we are doing here. Don't beat yourself up about poor changeset comments : it's a rather common case that all reviewers have to deal with. It's good to pick up good commenting practice early on though :) |
| 43156250 | about 9 years ago | Watch out for changeset comments that no longer match the changes made. iD makes it a bit too easy to reuse old comments without thinking about it. |
| 43155989 | about 9 years ago | Congrats on your first OSM edit :) It seems that you removed more than you intended however: this building may not be used by Quinn anymore, but it is still a building=warehouse (unless it's been demolished, in which case you'd want to delete the way completely, not just its tags). I'll let you re-add the building tag. Do you happen to know what the building is now used for ? |
| 17931964 | about 9 years ago | Is relation/3380720 really a cemetery ? Please comment on note/738153 |
| 42094150 | over 9 years ago | Hi, well done on your first OSM edit :) I doubt that Kirbys Brogue Inn is on the traffic island. Can you move it to the right location ? |