Diacritic's Comments
| Changeset | When | Comment |
|---|---|---|
| 111051481 | over 4 years ago | Hello, I haven't heard a response, and I can see you've been active. I'm reverting the geometry as per the reasoned mentioned above. Feel free to reach out if you wish to discuss. |
| 111408781 | over 4 years ago | It’s great to hear your interest; pedestrian infrastructure is often overlooked! For foot paths that are parallel to the road, you can use the additional tag footway=sidewalk (or by using Foot Path (sidewalk) in iD) to designate what we would refer to in Australia as a footpath. It might seem like a fussy difference, but it can make a difference when it comes to legal access to bikes (certain ages can ride on the footpath, etc). You’re not wrong doing it through your current tagging, but since you are putting the effort to map them all it would be a good opportunity to add more detail. :) |
| 110820035 | over 4 years ago | Hey! Awesome work around Shep. :) I wanted to give you a heads up about this edit. At Wyndham and Riverview, you’ve drawn Right turn lanes in the intersection which then overlap. Having the curves in the intersection causes routers to have a bit of a problem giving accurate turn instructions. For example, instead of telling the user to “turn right onto Riverview Drive” it might say “at the fork, stay left to merge onto Riverview”. Check out osm.wiki/Lanes#Motorway_with_lanes_and_destinations. I’d also recommend checking out thr dual carriageway wiki page for more info about splitting ways. We don’t generally use two lanes in each direction unless there is a physical barrier; otherwise we can use a single carriageway with “turn” and “lane” keys where needed. Hope this helps, happy to go into it more if you need; otherwise keep up the good work. :)
|
| 110820035 | over 4 years ago | Hey! Awesome work around Shep. :) I wanted to give you a heads up about this edit. At Wyndham and Riverview, you’ve drawn Right turn lanes in the intersection which then overlap. Having the curves in the intersection causes routers to have a bit of a problem giving accurate turn instructions. For example, instead of telling the user to “turn right onto Riverview Drive” it might say “at the fork, stay left to merge onto Riverview”. Check out osm.wiki/Lanes#Motorway_with_lanes_and_destinations. I’d also recommend checking out thr dual carriageway wiki page for more info about splitting ways. We don’t generally use two lanes in each direction unless there is a physical barrier; otherwise we can use a single carriageway with “turn” and “lane” keys where needed. Hope this helps, happy to go into it more if you need; otherwise keep up the good work. :)
|
| 111408781 | over 4 years ago | Hey, this is a big effort! Good work. :) Just wanted to check, is there any reason you are using the “Foot Path” tag, and not the “Foot Path (sidewalk)” tag? That would appear, at first glance, to be more accurate
|
| 110859201 | over 4 years ago | Thanks for your help Warin. I've just removed the multipolygon in #111277326; I think that resolves the issue? (Correct me if I'm mistaken) |
| 111092174 | over 4 years ago | Thank you for catching this Swavu. Looks perfect; apologies for the error. |
| 111051481 | over 4 years ago | Upon looking further, it appears your geometry changes have actually undone a significant amount of work I did in a recent edit, to remove duplicate ways where the carriageway is not split. The Right turn lane from Punt to Olympic, for example, has been split up the road from where it is actually separated. Routing software would interpret this as a fork in the road with a slip lane, rather than a right turn lane that ends before the main set of lights. Traffic lights have been moved from where the vehicles would stop to different locations. I'd like to clarify the reasons for this edits and moving the turn lanes away from where the carriageways split? |
| 110859201 | over 4 years ago | Hey Warin, I've just adjusted the tunnel layer, but I worked out why the building is level 2: The driveways at the east side of the building near Queens Bridge Street. Not sure the best way to resolve this, without adding more detail/separating the parts of the building? |
| 111051481 | over 4 years ago | Hi Supt_of_Printing, This change appears to have broken a couple of turn restrictions at the Olympic Boulevard U-Turn lanes. Namely, moving way node/9081524128 of the intersection node has created two additional junction nodes; nodes that don't appear to be neccessary. Having these additional junction nodes causes problems for routing services and can create unusual turn instructions that don't make sense for the real world. I'm not exactly sure why the turn u-turn lanes have changed from link ways either; to me it makes more sense for these to be considered as links to other streets rather than routes on ther own. Lastly, the geometry adjustments at Brunton Avenue have caused a mismatch between the lane restrictions, and the left turn lane of Brunton Avenue has been extended past where it returns to a single carriageway. The roadway also doesn't curve like the road you've drawn turning onto Punt; A car turning left onto Punt doesn't need to do a slight right before turning left onto the road; I would argue that drawing the right hand turn as such a steep curve doesn't accurately represent the nature of the junction; it's not a merge from a slip lane, it's a right hand turn. Happy to hear your thoughts on this. |
| 110859201 | over 4 years ago | Hey Warin! I wish it was that simple :) Firstly, Crown doesn't sit on a flat block of land. It's got multiple "street level" entrances that are at different heights and elevations. Yarra Promenade is much lower than Whiteman Street, for example, and lead to different levels of the complex. On the physical Ground level on the Whiteman Street side, we have Whiteman Street, the entrances to the undergound carpark, and a casino level. For whatever reason, this existing way was labelled as 'Level 2'; I didn't want to change it and mess with the order of things. From what I can tell, it is level 2, because it sits on top of the Yarra Promenade walkway and the carpark entrances on the south side of Whiteman. Now, immediately above the casino floor is another casino floor (believe it's a double height first level, and you have the nightclubs and crown towers above it). In between the two 'third levels', there is the bridge for Kings Way which cuts through the building. (fwiw, building was built around it, but that doesn't really matter) On top of the Kings way Bridge is the higest level of the building. This enclosed passage, within a building, is why I used the tunnel=building_passage tag. I intended to, in effect, "cut" the tunnel from the lower level of the crown building, but leave the higher level above it. If I have tagged this incorrectly, or have missed anything, I am more than happy to amend it. |
| 110241879 | over 4 years ago | Hey Aayudhi! I think you might have extended the toll tag a little too far on the West Gate Freeway. The tollway starts on the east side of Kings Way, (as Citylink), and then starts again northbound on at the Bolte Bridge turnoff. It's possible to turn left on Kings Way and continue to the WGB without paying a fee. There is a real nest of different lanes on the freeway with off/on ramps, so I'm happy to help out fixing some parts if you'd like? |