Cebderby's Comments
| Changeset | When | Comment |
|---|---|---|
| 91158882 | over 5 years ago | Please note that the Bing imagery is not well aligned in this area. Whenever you see every way and building offset by the same amount in the same direction, it is the imagery not the existing OSM features that needs to be moved. (Scroll down on Backgrounds tab in iD to see the adjustment tool). The background OS_OpenData_StreetView is also useful as a point of reference.
|
| 91062506 | over 5 years ago | Hi, the imagery OS_OpenData_StreetView does show the tunnel line under the main road if it helps. I'm guessing there are two footways, one on top of the other on the line you now have, one ramps down to the tunnel, a second ramps up the other way to the bridge to the car park roof grass? |
| 90877484 | over 5 years ago | NO, deleting existing data is not ok, the station serves both lines and is correctly labelled. You've added underground lines and are currently interested in them, but that does not mean that they are the only lines. I mentioned that there would be other values like Overground etc in the list in almost every comment I made. |
| 91055813 | over 5 years ago | Please take care to notice if all the roads and buildings all appear to be off by the same amount in the same direction, then it is likely the imagery that is off, not the OSM features. As an example, please note that even the nice new Bing imagery is quite poorly aligned around here, eg look at the roundabout and buildings at the north end of this changeset. If in doubt, a quick look at the OS_OpenData_StreetView layer if mapping in the UK is useful - if you see good alignment of OSM ways/buildings with that, then move imagery to match these features not the other way around. |
| 91055813 | over 5 years ago | Again, imagery used labelled as "Esri World Imagery;Bing Streetside;Mapillary Images;Mapillary Map Features;Mapillary Signs;OpenStreetCam Images",
|
| 91054320 | over 5 years ago | In this changeset, the imagery used is labelled as "Esri World Imagery;Bing Streetside;Mapillary Images;Mapillary Map Features;Mapillary Signs;OpenStreetCam Images;Esri World Imagery (Clarity) Beta;Mapbox Satellite", yet you have added 2 ways with source=maxar, and positioned then aligned with unaligned Esri imagery which is clearly way out.
|
| 90877484 | over 5 years ago | NO the node you indicate looks perfectly tagged.
I do not know where that page you refer to has come from. Looking at the history it seems to be the work of a single individual, before that a different? (or same with different account?) individual. OSM has consistent mapping across the world, there should be nothing conflicting in any local advice, just expected standards or maybe making a choice if there are different possible ways of doing something. I see a few some tram places mapped as if they were railway stations which I think is wrong. It is my understanding that there should be a stop_position on the track. There is no direct equivalent of railway=station for tram stopping places. |
| 90877484 | over 5 years ago | All done, actually used the normal JOSM upload command rather than the 'upload selected' I'd meant so all went in one go, but all is well. All the 'tflLine' is gone and looks like every station has 'line', any existing data that had comma separation was adjusted to semicolon so should be good to use. |
| 90877484 | over 5 years ago | The tool http://overpass-turbo.eu/
The other tool I used is JOSM which is an editor with all sorts of capabilities, and I did a certain amount of (careful, manual) text search-replace and cut and paste.
I'll apply the rest of the changes, I'll do it in a few chunks so each changeset is not too large, either spanning too large an area or numbers of stations. |
| 90877484 | over 5 years ago | No need, I have the data. Can you have a look at changeset/91010652, I find this tool useful:
|
| 90877484 | over 5 years ago | Thanks for the reply Aman Saraf. Sorry that my message yesterday was a bit abrupt, I was primarily hoping to stop you doing a lot of editing we may have had to undo. But the added data seems very precise and consistent so I'm sure it will be useful however it ends up.
|
| 90877484 | over 5 years ago | If 'line' is going to work for you (provided the data is complete and consistent) then that is is direction we should go, and move the new information you've added (but with uppercase and semicolons) over from 'tflLine' to 'line' where missing.
Sorry, my comment on abbreviations wasn't a good example, I only meant to avoid your "hammersmith-city" values and use "Hammersmith & City". Regarding bulk editing: for most purposes, it's important to use the normal editors in the normal manual fashion, it stops people getting into too much trouble and ensures every edit is checked not automated. However I think I can see a way I could carefully edit this data without another 270 changesets once we're happy. |
| 90877484 | over 5 years ago | Thanks for your prompt reply. Sorry if this reply gets a bit long, quite a few things to mention here.
|
| 90323107 | over 5 years ago | No reply; reverted |
| 90243042 | over 5 years ago | No reply; roundabout merges reverted, non divided way and alignment improvements reapplied. |
| 90877484 | over 5 years ago | What is the purpose of adding the unrecognised key "tflLine"? It is clear from this edit that you have seen the key "line", which is already present on 80 or so stations. How does this relate to the approx 270 subsequent edits of user Aman Saraf to add tflLine to each station? |
| 90890662 | over 5 years ago | Stop the vandalism
|
| 89274731 | over 5 years ago | Stop the vandalism
|
| 90890736 | over 5 years ago | 이 사용자의 모든 수정 사항 검토 |
| 90917773 | over 5 years ago | You should stop now as all these changes will have to be reverted.
|