ACarlotti's Comments
| Changeset | When | Comment |
|---|---|---|
| 88948541 | over 5 years ago | Have you read the OpenStreetMap guidance on mechanical edits (see osm.wiki/Automated_edits)? Also the guidance on good changeset comments is relevant (see osm.wiki/Good_changeset_comments).
1. This changeset does a lot of different things in a number of different locations. The changeset comment does not give any useful explanation for why you are making any of these changes. Even if they could be explained with a single useful changeset comment (which they can't), it would still be useful to split this up into multiple changesets covering a smaller geographic area, so that people view your changesets can get a better understanding of what places are affected by them (unfortunately the main tools for viewing changesets either show just the bounding box, don't work properly for relations, or don't work if the bounding box is too large).
Can you explain why you have made the changes you made here? For any mistakes you've made, can you please fix them (if possible) and try to avoid making them again in the future? Thanks,
|
| 88886552 | over 5 years ago | I think this tagging is generally better. However, I'm pretty sure there is not a central island on the east side of the roundabout (which is what I understand your tag there to mean). Also, when splitting ways, I think it's generally worth trying to preserve the way history on a sensible part of the way - in this changeset you've instead attached the history of three of the roads to a short stretch of way next to the roundabout. There's nothing I'd do to change it now, but it's something you could consider for future changes. It looks like you also made some change near the Milton Road/Elizaebth Way roundabout, possibly involving bus route 9, but I can't easily tell what it was. Also, I'm curious as to how this changeset was created by both Potlatch and JOSM. |
| 88616839 | over 5 years ago | Reverted in 88828701 |
| 88826180 | over 5 years ago | I think that improves some things. I've tidied up some further inconsistencies in 88828581; you might be interested in checking what I've done there. Overpass is usually good for viewing the changes in a changeset (though this doesn't show relations) - e.g. https://overpass-api.de/achavi/?changeset=88828581 |
| 88826215 | over 5 years ago | You also need to remove the construction=residential tags on those roads. |
| 88813395 | over 5 years ago | Hello egmont,
Also, your changeset comments don't say anything useful about what the changeset is doing, which makes it hard for other people (and you in the future) to work out what the intention of the changes was. If you are able to write more descriptive changeset comments in the future, that would be helpful. (This could be in any language - a good comment in a language someone can't read will be more helpful to them than a generic comment in a language they can read). You can read more about good changeset comments on the wiki (osm.wiki/Good_changeset_comments). |
| 88632986 | over 5 years ago | I think you've misunderstood how junctions of ways are mapped in OpenStreetMap. According to your changeset, it is no longer possible to get onto taxiway D from taxiway L, or onto the runway from taxiway D, since these ways do not connect (via a shared node). Assuming this is a mistake, can you correct it?
|
| 88801737 | over 5 years ago | This changeset covers a very large geographic area, which makes it very hard to work out what it actually affects. The changes in Scotland and the changes near Munich should ideally have been in separate changesets (I can't easily tell if you made any changes elsewhere - if so, then it probably should have been more than two changesets).
|
| 88786450 | over 5 years ago | One example is nodes 7773139223 and 7773139227, which lies on the way/58821394. Basically there is no relation between the end of a ditch and a point on the outline of Cambridge - there's no relation between the two, and the presence of one doesn't affect the presence of the other. So we use disjoint features to map them - no shared nodes. On the other hand, if you had a new footpath crossing over a road, then clearly this junction is meaningfully a common point on both objects, so we map it with the same node. JOSM makes it relatively easy to change objects back to earlier versions (or at least, I know how to do it fairly easily in JOSM). If you want, I can help you fix this (although for the other two boundaries I wouldn't just revert to the previous outlines, because I think they don't make sense in relation to each other). However, it's a minor thing, so I'll leave the data as it is for now to help you learn. |
| 88786499 | over 5 years ago | Looking at the Bing imagery, I'd agree that these paths meet at a single point, but I think that point is further north (the path to the east doesn't cross the corner of Charger Green).
|
| 88786450 | over 5 years ago | Hello mk270, and welcome to OpenStreetMap.
|
| 88641827 | over 5 years ago | Is there pedestrian and cycle access past this closure point? If so, then you need to add a short length of cycleway to connect this up. |
| 88616839 | over 5 years ago | Hello Bazzagazza101, and welcome to OpenStreetMap!
|
| 88529193 | over 5 years ago | It would be better to split up changes like this into separate changesets (one for each golf course affected). As it is, the changeset description here implies that you're only changing one golf course, which together with the large changeset bounding box suggests that you could have made some accidental changes elsewhere (though having looked more closely, I don't actually think that was the case here). |
| 88525807 | over 5 years ago | Apparently this bridge is not officially open yet (but in practice it is now being used). |
| 88314498 | over 5 years ago | I don't know how you reshaped it, but your changeset definitely created a multipolygon where there wasn't a multipolygon before. I've restored this to the original polygon, and deleted the node that was shared with the powerline.
|
| 88314498 | over 5 years ago | A few comments.
|
| 88421271 | over 5 years ago | I suggest mentioning buses in your changeset comments (e.g. "Update bus route 45a"), so that other people know what you're editing without looking at the contents of the changeset. (I thought it might be building numbers at first). |
| 87096896 | over 5 years ago | This changeset also contains a misinterpreation of aerial imagery. The outline you've drawn for the middle building is clearly showing the outline on Bing imagery, which was not taken directly overhead. The actual footprint on the ground is smaller - you've effectively mapped the roof in a different location to the ground floor, and shown it all as a single outline. Also, I'm pretty sure there is some stuff between this middle building and the large one to the right, though I can't tell what shape it is. (So it could be a building filling the entire gap, or it could just be one or two covered walkways). If you can't tell what it is, then it might be worth adding a note to the map so someone else can fix it later. I think this is all the feedback I have to offer for now, but feel free to ask me more questions. |
| 86784118 | over 5 years ago | I think there are some issues here too. The building to the west of High Street in particular looks as though it has been drawn by tracing around the approximate shape of a roof as viewed from an angle, and different roof heights and shadows might have been misinterpreted.
Also, if you're editing an existing building, it is almost always better retain the original OSM feature, and just edit the tags and move or replace the nodes as needed. This makes it much better to see the history of the building, and identify it as something that was already mapped, rather than something you're mapping for the first time. |